[PATCH] Fix missing include file in RTL8192U staging driver

[PATCH] Fix missing include file in RTL8192U staging driver

[Kamalesh Babulal]

Hi Greg,

	2.6.31-rc8 build fails with

drivers/staging/rtl8192su/r8192U_core.c:5086: error: implicit declaration of function 'vmalloc'
drivers/staging/rtl8192su/r8192U_core.c:5086: warning: cast to pointer from integer of different size
drivers/staging/rtl8192su/r8192U_core.c: In function 'rtl8192_usb_disconnect':
drivers/staging/rtl8192su/r8192U_core.c:12308: error: implicit declaration of function 'vfree'

Including the vmalloc.h file, fixes the build failure. I have tested the
patch for build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
 drivers/staging/rtl8192su/r8192U_core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
index 70f81a8..0734fec 100644
--- a/drivers/staging/rtl8192su/r8192U_core.c
+++ b/drivers/staging/rtl8192su/r8192U_core.c
@@ -75,6 +75,7 @@ double __extendsfdf2(float a) {return a;}
 #include "r8192U_dm.h"
 //#include "r8192xU_phyreg.h"
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 // FIXME: check if 2.6.7 is ok
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,7))
 #define usb_kill_urb usb_unlink_urb
@@ -102,6 +103,7 @@ double __extendsfdf2(float a) {return a;}
 #include "r8192U_dm.h"
 //#include "r8192xU_phyreg.h"
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 // FIXME: check if 2.6.7 is ok
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,7))
 #define usb_kill_urb usb_unlink_urb
			
			Kamalesh

Re: [PATCH] Fix missing include file in RTL8192U staging driver

[Greg KH]

On Thu, Sep 03, 2009 at 05:22:13PM +0530, Kamalesh Babulal wrote:
> Hi Greg,
> 
> 	2.6.31-rc8 build fails with
> 
> drivers/staging/rtl8192su/r8192U_core.c:5086: error: implicit declaration of function 'vmalloc'
> drivers/staging/rtl8192su/r8192U_core.c:5086: warning: cast to pointer from integer of different size
> drivers/staging/rtl8192su/r8192U_core.c: In function 'rtl8192_usb_disconnect':
> drivers/staging/rtl8192su/r8192U_core.c:12308: error: implicit declaration of function 'vfree'
> 
> Including the vmalloc.h file, fixes the build failure. I have tested the
> patch for build failure only.

On what arch are you hitting this?

This should all be resolved in the linux-next tree, right?

thanks,

greg k-h

Re: [PATCH] Fix missing include file in RTL8192U staging driver

[Kamalesh Babulal]

* Greg KH <gregkh@suse.de> [2009-09-03 11:04:53]:

> On Thu, Sep 03, 2009 at 05:22:13PM +0530, Kamalesh Babulal wrote:
> > Hi Greg,
> > 
> > 	2.6.31-rc8 build fails with
> > 
> > drivers/staging/rtl8192su/r8192U_core.c:5086: error: implicit declaration of function 'vmalloc'
> > drivers/staging/rtl8192su/r8192U_core.c:5086: warning: cast to pointer from integer of different size
> > drivers/staging/rtl8192su/r8192U_core.c: In function 'rtl8192_usb_disconnect':
> > drivers/staging/rtl8192su/r8192U_core.c:12308: error: implicit declaration of function 'vfree'
> > 
> > Including the vmalloc.h file, fixes the build failure. I have tested the
> > patch for build failure only.
> 
> On what arch are you hitting this?

It's on powerpc.
> 
> This should all be resolved in the linux-next tree, right?

Yes, linux-next tree already has a patch

commit 323308f10fc629d2276b6c97c5ecb9cdff0f5e65
Author: Jeff Mahoney <jeffm@suse.com>
Date:   Tue Aug 4 10:26:23 2009 -0400

    Staging: rtl8192su: add linux/vmalloc.h

sorry, which I missed.

> 
> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
			
			Kamalesh