* [2.6.31-rc8] Problem with detect USB devices
@ 2009-09-02 13:29 Maciej Rutecki
2009-09-02 13:42 ` Oliver Neukum
0 siblings, 1 reply; 10+ messages in thread
From: Maciej Rutecki @ 2009-09-02 13:29 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linus Torvalds, linux-usb
Bad version: 2.6.31-rc8
Last known good: 2.6.31-rc7
Observed on two different machines. Upgraded Debian Testing.
udev 0.141-2
hal 0.5.12~git20090406.46dc48-2
usbutils 0.84-1
==============================
Descriptions:
1. When plug usb flash drive and turn on computer, device manager in
KDE4 show it, and I can mount. When remove device very often icon
doesn't dissapear - KDE doesn't refresh informaton about connected
devices. When connect again, I can't mount it.
2. Sometimes when I remove and connect device again, then is listed twice:
http://unixy.pl/maciek/download/kernel/2.6.31-rc8/zlom/snap1.jpg
http://unixy.pl/maciek/download/kernel/2.6.31-rc8/zlom/snap2.jpg
3. Plug in flash drive (a), then flash drive (b), remove (a or b),
remove (b or a), KDE still shows icons of flash drive (a/b)
4. Similar with USB printer
5. I this cases (1-4) lsusb doesn't show connected devices
6. VirtualBox also has similar problem connect with USB devices.
==============================
For example:
a) Connect flash drive, turn on computer (similar when plug device after boot):
maciek@zlom:~/Desktop$ lsusb
[...]
Bus 001 Device 002: ID 3538:0054 Power Quotient International Co., Ltd
Flash Drive (2GB)
[...]
b) Mount:
lshal:
15:12:56.866: volume_uuid_599D_1168 property volume.mount_point = '/media/pqi'
15:12:56.867: volume_uuid_599D_1168 property volume.is_mounted = true
c) Unmount:
lshal:
15:13:46.528: volume_uuid_599D_1168 property volume.mount_point = ''
15:13:46.529: volume_uuid_599D_1168 property volume.is_mounted = false
maciek@zlom:~/Desktop$ lsusb
[...]
Bus 001 Device 002: ID 3538:0054 Power Quotient International Co., Ltd
Flash Drive (2GB)
[...]
d) Remove device:
lshal:
<doesn't show anything>
KDE4 device manager still shows icon of flash drive
maciek@zlom:~/Desktop$ lsusb
Bus 005 Device 003: ID 062a:0201 Creative Labs Defender Office
Keyboard (K7310) S Zodiak KM-9010
Bus 005 Device 002: ID 1020:0206 Labtec
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
dmesg:
[ 385.848532] usb 1-1: USB disconnect, address 2
e) Connect device:
lshal:
<doesn't show anything>
maciek@zlom:~/Desktop$ lsusb
Bus 005 Device 003: ID 062a:0201 Creative Labs Defender Office
Keyboard (K7310) S Zodiak KM-9010
Bus 005 Device 002: ID 1020:0206 Labtec
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
(can't see flash drive)
dmesg:
[ 483.727044] usb 1-1: new high speed USB device using ehci_hcd and address 5
[ 483.843749] usb 1-1: configuration #1 chosen from 1 choice
[ 483.844012] scsi5 : SCSI emulation for USB Mass Storage devices
[ 483.844222] usb-storage: device found at 5
[ 483.844225] usb-storage: waiting for device to settle before scanning
[ 488.845138] scsi 5:0:0:0: Direct-Access pqi
IntelligentStick 0.00 PQ: 0 ANSI: 2
[ 488.845354] sd 5:0:0:0: Attached scsi generic sg2 type 0
[ 488.846588] usb-storage: device scan complete
[ 488.846621] sd 5:0:0:0: [sdb] 2015231 512-byte logical blocks:
(1.03 GB/983 MiB)
[ 488.847350] sd 5:0:0:0: [sdb] Write Protect is off
[ 488.847355] sd 5:0:0:0: [sdb] Mode Sense: 00 00 00 00
[ 488.847359] sd 5:0:0:0: [sdb] Assuming drive cache: write through
[ 488.850727] sd 5:0:0:0: [sdb] Assuming drive cache: write through
[ 488.850733] sdb: sdb1
[ 488.960371] sd 5:0:0:0: [sdb] Assuming drive cache: write through
[ 488.960377] sd 5:0:0:0: [sdb] Attached SCSI removable disk
==============================
I try bisect, but I'm not sure that results is good:
root@zlom:/usr/src/git/linux-2.6# git bisect good
1e23502cc57cef33455ac7cb9111e3c6d991a894 is first bad commit
root@zlom:/usr/src/git/linux-2.6# git show
1e23502cc57cef33455ac7cb9111e3c6d991a894
commit 1e23502cc57cef33455ac7cb9111e3c6d991a894
Merge: e99b1f2 3161e45
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed Aug 26 20:54:48 2009 -0700
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
virtio: net refill on out-of-memory
smc91x: fix compilation on SMP
Config:
http://unixy.pl/maciek/download/kernel/2.6.31-rc8/zlom/config-2.6.31-rc8
dmesg:
http://unixy.pl/maciek/download/kernel/2.6.31-rc8/zlom/dmesg-2.6.31-rc8.txt
I have no idea, how debug it. Any help?
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-02 13:29 [2.6.31-rc8] Problem with detect USB devices Maciej Rutecki
@ 2009-09-02 13:42 ` Oliver Neukum
2009-09-02 14:15 ` Maciej Rutecki
0 siblings, 1 reply; 10+ messages in thread
From: Oliver Neukum @ 2009-09-02 13:42 UTC (permalink / raw)
To: Maciej Rutecki; +Cc: Linux Kernel Mailing List, Linus Torvalds, linux-usb
Am Mittwoch, 2. September 2009 15:29:48 schrieb Maciej Rutecki:
> have no idea, how debug it. Any help?
We have to find out where the event is lost. Please run
"udevadm monitor" and tell us whether you see an event as
you unplug your device.
HTH
Oliver
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-02 13:42 ` Oliver Neukum
@ 2009-09-02 14:15 ` Maciej Rutecki
2009-09-03 7:07 ` Oliver Neukum
0 siblings, 1 reply; 10+ messages in thread
From: Maciej Rutecki @ 2009-09-02 14:15 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Linux Kernel Mailing List, Linus Torvalds, linux-usb
2009/9/2 Oliver Neukum <oliver@neukum.org>:
> We have to find out where the event is lost. Please run
> "udevadm monitor" and tell us whether you see an event as
> you unplug your device.
Thanks for response.
1. Start monitor:
root@zlom:/home/maciek# udevadm monitor
monitor will print the received events for:
UDEV - the event which udev sends out after rule processing
KERNEL - the kernel uevent
2. Connect device:
KERNEL[1251900238.630740] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1 (usb)
KERNEL[1251900238.631294] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
UDEV [1251900238.635817] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1 (usb)
KERNEL[1251900238.658567] add /module/usb_storage (module)
UDEV [1251900238.659543] add /module/usb_storage (module)
KERNEL[1251900238.660124] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
KERNEL[1251900238.660161] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/scsi_host/host4
(scsi_host)
KERNEL[1251900238.660208] add /bus/usb/drivers/usb-storage (drivers)
UDEV [1251900238.664418] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
UDEV [1251900238.666087] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
UDEV [1251900238.666997] add /bus/usb/drivers/usb-storage (drivers)
UDEV [1251900238.667274] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/scsi_host/host4
(scsi_host)
KERNEL[1251900243.666195] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0
(scsi)
KERNEL[1251900243.666298] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0
(scsi)
KERNEL[1251900243.666388] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_disk/4:0:0:0
(scsi_disk)
KERNEL[1251900243.666461] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_device/4:0:0:0
(scsi_device)
KERNEL[1251900243.666564] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_generic/sg2
(scsi_generic)
UDEV [1251900243.668787] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0
(scsi)
KERNEL[1251900243.669784] change
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0
(scsi)
UDEV [1251900243.675609] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0
(scsi)
UDEV [1251900243.675920] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_disk/4:0:0:0
(scsi_disk)
UDEV [1251900243.679152] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_device/4:0:0:0
(scsi_device)
UDEV [1251900243.679597] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_generic/sg2
(scsi_generic)
UDEV [1251900243.681201] change
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0
(scsi)
KERNEL[1251900243.780545] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb
(block)
KERNEL[1251900243.780596] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb/sdb1
(block)
KERNEL[1251900243.780625] add /devices/virtual/bdi/8:16 (bdi)
UDEV [1251900243.784615] add /devices/virtual/bdi/8:16 (bdi)
UDEV [1251900243.955713] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb
(block)
UDEV [1251900243.990627] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb/sdb1
(block)
maciek@zlom:~$ lsusb
Bus 005 Device 003: ID 062a:0201 Creative Labs Defender Office
Keyboard (K7310) S Zodiak KM-9010
Bus 005 Device 002: ID 1020:0206 Labtec
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 004: ID 3538:0054 Power Quotient International Co., Ltd
Flash Drive (2GB)
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
3. Disconnect:
KERNEL[1251900287.925502] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_generic/sg2
(scsi_generic)
KERNEL[1251900287.925554] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_device/4:0:0:0
(scsi_device)
KERNEL[1251900287.925604] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_disk/4:0:0:0
(scsi_disk)
KERNEL[1251900287.925680] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb/sdb1
(block)
KERNEL[1251900287.925721] remove /devices/virtual/bdi/8:16 (bdi)
KERNEL[1251900287.925819] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb
(block)
KERNEL[1251900287.925850] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0
(scsi)
KERNEL[1251900287.925893] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0
(scsi)
KERNEL[1251900287.925944] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/scsi_host/host4
(scsi_host)
KERNEL[1251900287.925994] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
KERNEL[1251900287.926058] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
KERNEL[1251900287.926302] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1 (usb)
UDEV [1251900287.927833] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_disk/4:0:0:0
(scsi_disk)
UDEV [1251900287.928827] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_generic/sg2
(scsi_generic)
UDEV [1251900287.929674] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/scsi_device/4:0:0:0
(scsi_device)
UDEV [1251900287.936095] remove
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4/target4:0:0/4:0:0:0/block/sdb/sdb1
(block)
maciek@zlom:~$ lsusb
Bus 005 Device 003: ID 062a:0201 Creative Labs Defender Office
Keyboard (K7310) S Zodiak KM-9010
Bus 005 Device 002: ID 1020:0206 Labtec
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
4. Connect again:
KERNEL[1251900489.897750] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1 (usb)
KERNEL[1251900489.897896] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
KERNEL[1251900489.898108] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5 (scsi)
KERNEL[1251900489.898147] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/scsi_host/host5
(scsi_host)
KERNEL[1251900494.900911] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0
(scsi)
KERNEL[1251900494.900974] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0
(scsi)
KERNEL[1251900494.901005] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0/scsi_disk/5:0:0:0
(scsi_disk)
KERNEL[1251900494.901040] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0/scsi_device/5:0:0:0
(scsi_device)
KERNEL[1251900494.901074] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0/scsi_generic/sg2
(scsi_generic)
KERNEL[1251900494.904546] change
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0
(scsi)
KERNEL[1251900495.015049] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0/block/sdb
(block)
KERNEL[1251900495.015133] add
/devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host5/target5:0:0/5:0:0:0/block/sdb/sdb1
(block)
KERNEL[1251900495.015237] add /devices/virtual/bdi/8:16 (bdi)
maciek@zlom:~$ lsusb
Bus 005 Device 003: ID 062a:0201 Creative Labs Defender Office
Keyboard (K7310) S Zodiak KM-9010
Bus 005 Device 002: ID 1020:0206 Labtec
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>
> HTH
> Oliver
>
>
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-02 14:15 ` Maciej Rutecki
@ 2009-09-03 7:07 ` Oliver Neukum
2009-09-03 16:05 ` Greg KH
0 siblings, 1 reply; 10+ messages in thread
From: Oliver Neukum @ 2009-09-03 7:07 UTC (permalink / raw)
To: Maciej Rutecki, greg; +Cc: Linux Kernel Mailing List, Linus Torvalds, linux-usb
Am Mittwoch, 2. September 2009 16:15:28 schrieb Maciej Rutecki:
> KERNEL[1251900287.925994] remove
> /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
> KERNEL[1251900287.926058] remove
> /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
You are definitely seeing the correct kernel events.
So it must be an indirect problem.
Greg, any changes in sysfs between rc7 and rc8?
Regards
Oliver
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-03 7:07 ` Oliver Neukum
@ 2009-09-03 16:05 ` Greg KH
2009-09-04 10:23 ` Oliver Neukum
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2009-09-03 16:05 UTC (permalink / raw)
To: Oliver Neukum
Cc: Maciej Rutecki, Linux Kernel Mailing List, Linus Torvalds,
linux-usb
On Thu, Sep 03, 2009 at 09:07:01AM +0200, Oliver Neukum wrote:
> Am Mittwoch, 2. September 2009 16:15:28 schrieb Maciej Rutecki:
> > KERNEL[1251900287.925994] remove
> > /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
> > KERNEL[1251900287.926058] remove
> > /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
>
> You are definitely seeing the correct kernel events.
> So it must be an indirect problem.
>
> Greg, any changes in sysfs between rc7 and rc8?
No, not that I sent in.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-03 16:05 ` Greg KH
@ 2009-09-04 10:23 ` Oliver Neukum
2009-09-04 14:10 ` Maciej Rutecki
0 siblings, 1 reply; 10+ messages in thread
From: Oliver Neukum @ 2009-09-04 10:23 UTC (permalink / raw)
To: Greg KH
Cc: Maciej Rutecki, Linux Kernel Mailing List, Linus Torvalds,
linux-usb
Am Donnerstag, 3. September 2009 18:05:36 schrieb Greg KH:
> On Thu, Sep 03, 2009 at 09:07:01AM +0200, Oliver Neukum wrote:
> > Am Mittwoch, 2. September 2009 16:15:28 schrieb Maciej Rutecki:
> > > KERNEL[1251900287.925994] remove
> > > /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0/host4 (scsi)
> > > KERNEL[1251900287.926058] remove
> > > /devices/pci0000:00/0000:00:1d.7/usb1/1-1/1-1:1.0 (usb)
> >
> > You are definitely seeing the correct kernel events.
> > So it must be an indirect problem.
> >
> > Greg, any changes in sysfs between rc7 and rc8?
>
> No, not that I sent in.
Maciej,
can you run a git bisection?
Regards
Oliver
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-04 10:23 ` Oliver Neukum
@ 2009-09-04 14:10 ` Maciej Rutecki
2009-09-04 18:30 ` Maciej Rutecki
0 siblings, 1 reply; 10+ messages in thread
From: Maciej Rutecki @ 2009-09-04 14:10 UTC (permalink / raw)
To: Oliver Neukum
Cc: Greg KH, Linux Kernel Mailing List, Linus Torvalds, linux-usb
2009/9/4 Oliver Neukum <oliver@neukum.org>:
>
> Maciej,
>
> can you run a git bisection?
>
> Regards
> Oliver
>
>
I run one bisection, but result may not be correct. I try again on
another machine (which has the same problem).
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-04 14:10 ` Maciej Rutecki
@ 2009-09-04 18:30 ` Maciej Rutecki
2009-09-04 18:35 ` Eric Paris
0 siblings, 1 reply; 10+ messages in thread
From: Maciej Rutecki @ 2009-09-04 18:30 UTC (permalink / raw)
To: Oliver Neukum
Cc: Greg KH, Linux Kernel Mailing List, Linus Torvalds, linux-usb,
ebiederm, eparis
2009/9/4 Maciej Rutecki <maciej.rutecki@gmail.com>:
> 2009/9/4 Oliver Neukum <oliver@neukum.org>:
>
>>
>> Maciej,
>>
>> can you run a git bisection?
>>
0db501bd0610ee0c0aca84d927f90bcccd09e2bd is first bad commit
commit 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
Author: Eric W. Biederman <ebiederm@xmission.com>
Date: Thu Aug 27 03:20:04 2009 -0700
inotify: Ensure we alwasy write the terminating NULL.
Before the rewrite copy_event_to_user always wrote a terqminating '\0'
byte to user space after the filename. Since the rewrite that
terminating byte was skipped if your filename is exactly a multiple of
event_size. Ouch!
So add one byte to name_size before we round up and use clear_user to
set userspace to zero like /dev/zero does instead of copying the
strange nul_inotify_event. I can't quite convince myself len_to_zero
will never exceed 16 and even if it doesn't clear_user should be more
efficient and a more accurate reflection of what the code is trying to
do.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
:040000 040000 ae8bc8bebfd205cde1f7b7689f60a2ada08b1e24
7be919a71e3e27510ec38f95664a5e770ce82ad8 M fs
Unfortunately I cannot revert it (to make sure):
root@gumis:/usr/src/git/linux-2.6# git revert
0db501bd0610ee0c0aca84d927f90bcccd09e2bd
Automatic revert failed. After resolving the conflicts,
mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
and commit the result.
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-04 18:30 ` Maciej Rutecki
@ 2009-09-04 18:35 ` Eric Paris
2009-09-04 20:16 ` Maciej Rutecki
0 siblings, 1 reply; 10+ messages in thread
From: Eric Paris @ 2009-09-04 18:35 UTC (permalink / raw)
To: Maciej Rutecki
Cc: Oliver Neukum, Greg KH, Linux Kernel Mailing List, Linus Torvalds,
linux-usb, ebiederm
On Fri, 2009-09-04 at 20:30 +0200, Maciej Rutecki wrote:
> 2009/9/4 Maciej Rutecki <maciej.rutecki@gmail.com>:
> > 2009/9/4 Oliver Neukum <oliver@neukum.org>:
> >
> >>
> >> Maciej,
> >>
> >> can you run a git bisection?
> >>
>
>
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd is first bad commit
> commit 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Thu Aug 27 03:20:04 2009 -0700
>
> inotify: Ensure we alwasy write the terminating NULL.
>
> Before the rewrite copy_event_to_user always wrote a terqminating '\0'
> byte to user space after the filename. Since the rewrite that
> terminating byte was skipped if your filename is exactly a multiple of
> event_size. Ouch!
>
> So add one byte to name_size before we round up and use clear_user to
> set userspace to zero like /dev/zero does instead of copying the
> strange nul_inotify_event. I can't quite convince myself len_to_zero
> will never exceed 16 and even if it doesn't clear_user should be more
> efficient and a more accurate reflection of what the code is trying to
> do.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
> Signed-off-by: Eric Paris <eparis@redhat.com>
>
> :040000 040000 ae8bc8bebfd205cde1f7b7689f60a2ada08b1e24
> 7be919a71e3e27510ec38f95664a5e770ce82ad8 M fs
>
> Unfortunately I cannot revert it (to make sure):
> root@gumis:/usr/src/git/linux-2.6# git revert
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Automatic revert failed. After resolving the conflicts,
> mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
> and commit the result.
Update to Linus's newest git tree. It has a fix for this problem.
Sorry for all the trouble.
-Eric
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.31-rc8] Problem with detect USB devices
2009-09-04 18:35 ` Eric Paris
@ 2009-09-04 20:16 ` Maciej Rutecki
0 siblings, 0 replies; 10+ messages in thread
From: Maciej Rutecki @ 2009-09-04 20:16 UTC (permalink / raw)
To: Eric Paris
Cc: Oliver Neukum, Greg KH, Linux Kernel Mailing List, Linus Torvalds,
linux-usb, ebiederm
2009/9/4 Eric Paris <eparis@redhat.com>:
>
> Update to Linus's newest git tree. It has a fix for this problem.
> Sorry for all the trouble.
Yes, upgrade to latest git tree solves problem. Thanks.
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-09-04 20:17 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-02 13:29 [2.6.31-rc8] Problem with detect USB devices Maciej Rutecki
2009-09-02 13:42 ` Oliver Neukum
2009-09-02 14:15 ` Maciej Rutecki
2009-09-03 7:07 ` Oliver Neukum
2009-09-03 16:05 ` Greg KH
2009-09-04 10:23 ` Oliver Neukum
2009-09-04 14:10 ` Maciej Rutecki
2009-09-04 18:30 ` Maciej Rutecki
2009-09-04 18:35 ` Eric Paris
2009-09-04 20:16 ` Maciej Rutecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox