From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
Roland McGrath <roland@redhat.com>,
Tom Horsley <tom.horsley@att.net>,
linux-kernel@vger.kernel.org
Subject: Re: binfmt_flat.c && bprm->cred (Was: [PATCH 0/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex)
Date: Thu, 3 Sep 2009 21:09:58 +0400 [thread overview]
Message-ID: <20090903170958.GE5485@lenovo> (raw)
In-Reply-To: <20090903165850.GC5485@lenovo>
[Cyrill Gorcunov - Thu, Sep 03, 2009 at 08:58:50PM +0400]
...
| ...
| | -static int load_flat_shared_library(int id, struct lib_info *libs)
| | +static int load_flat_shared_library(struct linux_binprm *bprm, int id,
| | + struct lib_info *libs)
| | {
| ...
| | + sprintf(buf, "/lib/lib%d.so", id);
|
| Hi Oleg, perhaps it is a good moment to switch sprintf to snprintf
| as well? buf is only 16 bytes long so we have 4 byte room for number.
| Not sure if it's possible to have 10000 relocs though :) Just a thought.
| Most probably I miss something.
|
| -- Cyrill
Sigh... I'm idiot. We have MAX_SHARED_LIBS limit here. Drop my question
please. Sorry for noise.
-- Cyrill
next prev parent reply other threads:[~2009-09-03 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 16:05 [PATCH 0/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex Oleg Nesterov
2009-09-03 16:29 ` binfmt_flat.c && bprm->cred (Was: [PATCH 0/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex) Oleg Nesterov
2009-09-03 16:58 ` Cyrill Gorcunov
2009-09-03 17:09 ` Cyrill Gorcunov [this message]
2009-09-03 17:58 ` Oleg Nesterov
2009-09-04 8:47 ` [PATCH 0/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex David Howells
2009-09-04 9:22 ` Roland McGrath
2009-09-04 9:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903170958.GE5485@lenovo \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tom.horsley@att.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox