public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] - Fix cacheflush address in change_page_attr_set_clr()
@ 2009-09-03 17:56 Jack Steiner
  0 siblings, 0 replies; only message in thread
From: Jack Steiner @ 2009-09-03 17:56 UTC (permalink / raw)
  To: mingo, tglx; +Cc: linux-kernel

Fix address passed to cpa_flush_range() when changing page
attributes from WB to UC. The address (*addr) is
modified by __change_page_attr_set_clr(). The result is that
the pages being flushed start at the _end_ of the changed range
instead of the beginning.

Signed-off-by: Jack Steiner <steiner@sgi.com>


---
 arch/x86/mm/pageattr.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c	2009-08-31 13:34:18.000000000 -0500
+++ linux/arch/x86/mm/pageattr.c	2009-09-03 12:48:50.000000000 -0500
@@ -822,6 +822,7 @@ static int change_page_attr_set_clr(unsi
 {
 	struct cpa_data cpa;
 	int ret, cache, checkalias;
+	unsigned long baddr = 0;
 
 	/*
 	 * Check, if we are requested to change a not supported
@@ -853,6 +854,11 @@ static int change_page_attr_set_clr(unsi
 			 */
 			WARN_ON_ONCE(1);
 		}
+		/*
+		 * Save address for cache flush. *addr is modified in the call
+		 * to __change_page_attr_set_clr() below.
+		 */
+		baddr = *addr;
 	}
 
 	/* Must avoid aliasing mappings in the highmem code */
@@ -900,7 +906,7 @@ static int change_page_attr_set_clr(unsi
 			cpa_flush_array(addr, numpages, cache,
 					cpa.flags, pages);
 		} else
-			cpa_flush_range(*addr, numpages, cache);
+			cpa_flush_range(baddr, numpages, cache);
 	} else
 		cpa_flush_all(cache);
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-03 17:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-03 17:56 [PATCH] - Fix cacheflush address in change_page_attr_set_clr() Jack Steiner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox