From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Make sure the value in abs() does not get truncated if it is greater than 2^32
Date: Thu, 3 Sep 2009 23:12:01 +0200 [thread overview]
Message-ID: <200909032312.10418.eike-kernel@sf-tec.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
I was just digging a bit around in linux/kernel.h and stumbled over the abs()
makro. For me it looks as it would return wrong results on 64 bit platforms
if the input value is greater than 2^32.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
include/linux/kernel.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index d6320a3..1e6eb66 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -145,7 +145,7 @@ extern int _cond_resched(void);
#define might_sleep_if(cond) do { if (cond) might_sleep(); } while (0)
#define abs(x) ({ \
- int __x = (x); \
+ long __x = (x); \
(__x < 0) ? -__x : __x; \
})
--
1.6.0.2
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2009-09-03 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 21:12 Rolf Eike Beer [this message]
2009-09-10 20:39 ` [PATCH] Make sure the value in abs() does not get truncated if it is greater than 2^32 Andrew Morton
2009-09-11 5:28 ` Rolf Eike Beer
2009-09-11 22:54 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909032312.10418.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox