Re: [PATCH] basic perf support for sparc

[Ingo Molnar <mingo@elte.hu>]

* David Miller <davem@davemloft.net> wrote:

> From: Jens Axboe <jens.axboe@oracle.com>
> Date: Mon, 17 Aug 2009 08:48:51 +0200
> 
> >     sparc: add basic support for 'perf'
> >     
> >     This wires up the perf_counter_open() syscall so that basic
> >     software support for perf is working.
> >     
> >     Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> 
> Does this build for you without adding an
> arch/sparc/include/asm/perf_counter.h that looks
> something like the following?
> 
> #ifndef _ASM_SPARC_PERF_COUNTER_H
> #define _ASM_SPARC_PERF_COUNTER_H
> 
> #define PERF_COUNTER_INDEX_OFFSET	0
> 
> #endif
> 
> Or is this somehow now required in the -tip trees?

This used to be required but i recently fixed this (and that fix is 
upstream as well) via:

  f738eb1: perf_counter: Fix the PARISC build

there's now a default define of 0 so you dont have to define it and 
can leave out this chunk.

( That index is only interesting if the architecture has a way to 
  allow unprivileged user-space to access counter registers 
  directly. In that case the index reflects the offset from the 
  (constantly changing) dynamix index which we put into the mmap 
  header. With Sparc not having a hw-PMU implementation this index 
  is entirely uninteresting at this stage. )

	Ingo