public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix missing include file in RTL8192U staging driver
Date: Fri, 4 Sep 2009 10:51:07 +0530	[thread overview]
Message-ID: <20090904052107.GA4883@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090903180453.GA25231@suse.de>

* Greg KH <gregkh@suse.de> [2009-09-03 11:04:53]:

> On Thu, Sep 03, 2009 at 05:22:13PM +0530, Kamalesh Babulal wrote:
> > Hi Greg,
> > 
> > 	2.6.31-rc8 build fails with
> > 
> > drivers/staging/rtl8192su/r8192U_core.c:5086: error: implicit declaration of function 'vmalloc'
> > drivers/staging/rtl8192su/r8192U_core.c:5086: warning: cast to pointer from integer of different size
> > drivers/staging/rtl8192su/r8192U_core.c: In function 'rtl8192_usb_disconnect':
> > drivers/staging/rtl8192su/r8192U_core.c:12308: error: implicit declaration of function 'vfree'
> > 
> > Including the vmalloc.h file, fixes the build failure. I have tested the
> > patch for build failure only.
> 
> On what arch are you hitting this?

It's on powerpc.
> 
> This should all be resolved in the linux-next tree, right?

Yes, linux-next tree already has a patch

commit 323308f10fc629d2276b6c97c5ecb9cdff0f5e65
Author: Jeff Mahoney <jeffm@suse.com>
Date:   Tue Aug 4 10:26:23 2009 -0400

    Staging: rtl8192su: add linux/vmalloc.h

sorry, which I missed.

> 
> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
			
			Kamalesh

      reply	other threads:[~2009-09-04  5:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 11:52 [PATCH] Fix missing include file in RTL8192U staging driver Kamalesh Babulal
2009-09-03 18:04 ` Greg KH
2009-09-04  5:21   ` Kamalesh Babulal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904052107.GA4883@linux.vnet.ibm.com \
    --to=kamalesh@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox