public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Marton Balint <cus@fazekas.hu>, Andreas Mohr <andi@lisas.de>,
	linux-kernel@vger.kernel.org
Subject: Re: CPU scheduler weirdness?
Date: Fri, 4 Sep 2009 14:40:54 +0200	[thread overview]
Message-ID: <20090904124054.GA9490@elte.hu> (raw)
In-Reply-To: <1252053631.7564.2.camel@twins>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, 2009-09-03 at 23:57 +0200, Marton Balint wrote:
> > > sched: fine-tune SD_MC_INIT:
> > > 14800984706bf6936bbec5187f736e928be5c218
> > >
> > > If I add again the removed SD_BALANCE_NEWIDLE to flags, then everything works 
> > > as expected. So what would be the correct fix for this bug? Revert the patch? 
> > > Or just add SD_BALANCE_NEWIDLE to flags?
> > 
> > 
> > Ingo, Peter, could any of you guys have a look at the commit 
> > that caused this bug? Is it OK to revert it? Or a fix somewhere 
> > else is necessary? I'm pushing this because I hope that this bug 
> > will get fixed in the upcoming stable kernel...
> 
> I'm fine with re-adding SD_BALANCE_IDLE and SD_WAKE_IDLE on 
> SMT/MC/CPU levels.
> 
> Ingo?

Ok, agreed. I have re-benchmarked a couple of key workload and it 
seems like a good change, on top of your load-balancer fixes.

Marton, could you please double check the latest -tip tree:

  http://people.redhat.com/mingo/tip.git/README

Does it resolve the problem?

Thanks,

	Ingo

  reply	other threads:[~2009-09-04 12:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13  0:58 CPU scheduler weirdness? Marton Balint
2009-08-13  8:42 ` Andreas Mohr
2009-08-13 15:39   ` Marton Balint
2009-08-13 15:58     ` Andreas Mohr
2009-08-18 19:49       ` Marton Balint
2009-08-19  7:04         ` Peter Zijlstra
2009-08-19 12:01           ` Marton Balint
2009-08-19 12:10             ` Peter Zijlstra
2009-08-19 12:34               ` Marton Balint
2009-08-19 18:42                 ` Peter Zijlstra
2009-08-20  0:10                   ` Marton Balint
2009-08-20 10:56                     ` Ingo Molnar
2009-08-20 16:56                       ` Marton Balint
2009-08-29 14:15                         ` Marton Balint
2009-09-03 21:57                           ` Marton Balint
2009-09-04  6:26                             ` Mike Galbraith
2009-09-04  7:53                               ` Marton Balint
2009-09-04 12:26                                 ` Mike Galbraith
2009-09-04  8:40                             ` Peter Zijlstra
2009-09-04 12:40                               ` Ingo Molnar [this message]
2009-09-04 15:31                                 ` Marton Balint

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904124054.GA9490@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@lisas.de \
    --cc=cus@fazekas.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox