From: Andrew Morton <akpm@linux-foundation.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: jgunthorpe@obsidianresearch.com,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
srajiv@linux.vnet.ibm.com, debora@linux.vnet.ibm.com,
m.selhorst@sirrix.com, jmorris@namei.org, jbeulich@novell.com
Subject: Re: [PATCH] TPM: Fixup pubek sysfs file
Date: Fri, 4 Sep 2009 14:03:25 -0700 [thread overview]
Message-ID: <20090904140325.c592289a.akpm@linux-foundation.org> (raw)
In-Reply-To: <adaab1bnvz3.fsf@cisco.com>
On Thu, 03 Sep 2009 22:02:24 -0700
Roland Dreier <rdreier@cisco.com> wrote:
>
> > Algorithm: 00 00 00 01
> > Encscheme: 00 03
> > Sigscheme: 00 01
> > Parameters: 00 00 08 00 00 00 00 02 00 00 00 00
> > Modulus length: 256
>
> No argument that this fix is an improvement, but what happened to the
> "one value per file" rule for sysfs??
We goofed. This one snuck through.
It's one of the reasons why I recommend that people cite examples of
the sysfs/procfs output in changelogs. These things are part of the
kernel ABI and once they go in we cannot change them so we have to get
them right first time.
next prev parent reply other threads:[~2009-09-04 21:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 4:52 [PATCH] TPM: Fixup pubek sysfs file Jason Gunthorpe
2009-09-04 5:02 ` Roland Dreier
2009-09-04 21:03 ` Andrew Morton [this message]
2009-09-04 21:23 ` Jason Gunthorpe
2009-09-11 16:28 ` Greg KH
[not found] ` <17754_1252731784_n8C533ou010944_20090911162837.GC17677@kroah.com>
2009-09-14 18:01 ` [tpmdd-devel] " Jonathan M. McCune
2009-09-14 18:34 ` Rajiv Andrade
2009-09-14 18:43 ` Jason Gunthorpe
2009-09-14 19:23 ` Jonathan M. McCune
2009-09-14 19:46 ` Jason Gunthorpe
2009-09-14 19:50 ` Greg KH
2009-09-15 3:06 ` Mimi Zohar
2009-09-15 18:52 ` Jonathan M. McCune
2009-09-15 16:34 ` Hal Finney
2009-09-11 16:28 ` Greg KH
2009-09-14 20:48 ` Rajiv Andrade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904140325.c592289a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=debora@linux.vnet.ibm.com \
--cc=jbeulich@novell.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.selhorst@sirrix.com \
--cc=rdreier@cisco.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox