Re: asm-generic update candidates?

Arnd Bergmann
2009-09-08T12:55:49Z

On Friday 04 September 2009, Robin Getz wrote:
> On Fri 4 Sep 2009 09:32, Arnd Bergmann pondered:
> > On Thursday 03 September 2009, Robin Getz wrote:
> > Also, my plan is to do one architecture at a time,
>
> Which arch are you starting with?

I've done patches for microblaze, powerpc and x86, and some arch
maintainers have done more. I'd probably do s390 next and see who
else is submitting patches for their architectures in 2.6.32,
then work on those remaining. Feel free to grab any one whose
maintainer you can get hold of.

> > > Do you keep a list somewhere?
> >
> > Well, this is how I started out writing doing the common files
> > in the first place. I looked at the most similar files, and then
> > used vimdiff on up to four files at a time, changing them to
> > be exactly identical by editing out all the bitrot.
> >
> > In general, if a file exists in asm-generic, it should be usable
> > by some of the architectures, if it does not exist then either it
> > is too hard to make a generic version or I have not looked at it
> > yet.
>
> OK -- here are some identical ones:
>
> 8253pit.h (alpha and power)

PIT is interesting, there is also 8253.h in some architectures.
This could use a larger rework, I've started on bits of it
and should probably look which patches are still needed.

> fbio.h (m68k and sparc)

It seems that m68k FB_SUN3 support was removed a long time ago,
so this one is really just sparc specific.

> md.h (h8300, alpha and m68k)

This file does not appear to be used at all, we should probably
remove it.

> I also noticed in Linus's latest (last commit
> 37d0892c5a94e208cf863e3b7bac014edee4346d):
>
> cat arch/microblaze/include/asm/ipc.h
> #include <asm-generic/ipc.h>
>
> but: ls include/asm-generic/ipc.h
> ls: cannot access include/asm-generic/ipc.h: No such file or directory

Adrian Bunk killed that file in asm/ back in 2007, he probably crossed
patches with the microblaze architecture.