public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Assmann <sassmann@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jcm@redhat.com, sdietrich@novell.com, linux-acpi@vger.kernel.org,
	andi@firstfloor.org, hpa@zytor.com,
	Stefan Assmann <sassmann@redhat.com>,
	mingo@elte.hu, lenb@kernel.org, ktokunag@redhat.com,
	tglx@linutronix.de, Olaf.Dabrunz@gmx.net
Subject: [RFC][PATCH 1/2] show Intel QuickPath Interconnect Routing and Protocol Layer Registers in PCI config space
Date: Fri, 4 Sep 2009 12:55:35 -0400	[thread overview]
Message-ID: <20090904165535.26294.95511.sendpatchset@t500> (raw)
In-Reply-To: <20090904165525.26294.31112.sendpatchset@t500>

On some machines with Intel X58 or Intel 55x0 chipset the Intel QuickPath
Interconnect Routing and Protocol Layer Registers or not exposed to PCI config
space. Access to these is necessary to disable boot interrupts in the QPI
Protocol Interrupt Control Register.
DEVHIDE1 provides a method to (un)hide the PCI config space of devices inside
the IOH and is altered to guarantee that PCI config space is accessible.
See Intel document #320838-003, sections 17.6.5.10 and 17.11.2.21.

Signed-off-by: Stefan Assmann <sassmann@redhat.com>
---
 drivers/pci/quirks.c    |   24 ++++++++++++++++++++++++
 include/linux/pci_ids.h |    1 +
 2 files changed, 25 insertions(+)

--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1612,6 +1612,30 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
 DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL,   PCI_DEVICE_ID_INTEL_ESB_10, 	quirk_disable_intel_boot_interrupt);
 
 /*
+ * Show Intel QuickPath Interconnect Routing and Protocol Layer Registers
+ * in PCI config space (ensures access to QPIPINTRC).
+ * See Intel document #320838-003, sections 17.6.5.10 and 17.11.2.21.
+ */
+#define INTEL_X58_55x0_DEVHIDE1_REG	0xf2
+#define INTEL_X58_55x0_HIDE_DEV17_FUN0	(1<<12)
+#define INTEL_X58_55x0_HIDE_DEV17_FUN1	(1<<13)
+
+static void quirk_show_intel_qpi_conf_register(struct pci_dev *dev)
+{
+	u16 pci_config_word;
+
+	pci_read_config_word(dev, INTEL_X58_55x0_DEVHIDE1_REG, &pci_config_word);
+	pci_config_word &= ~(INTEL_X58_55x0_HIDE_DEV17_FUN0 |
+			     INTEL_X58_55x0_HIDE_DEV17_FUN1);
+	pci_write_config_word(dev, INTEL_X58_55x0_DEVHIDE1_REG, pci_config_word);
+
+	/* need to rescan the bus for changes to take effect */
+	pci_rescan_bus(dev->bus);
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_IOAT_TBG9,	quirk_show_intel_qpi_conf_register);
+DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_IOAT_TBG9,	quirk_show_intel_qpi_conf_register);
+
+/*
  * disable boot interrupts on HT-1000
  */
 #define BC_HT1000_FEATURE_REG		0x64
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2508,6 +2508,7 @@
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG5	0x342a
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG6	0x342b
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG7	0x342c
+#define PCI_DEVICE_ID_INTEL_IOAT_TBG9	0x342e
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG0	0x3430
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG1	0x3431
 #define PCI_DEVICE_ID_INTEL_IOAT_TBG2	0x3432

  reply	other threads:[~2009-09-04 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 16:55 [RFC][PATCH 0/2] boot interrupts on Intel X58 and 55x0 Stefan Assmann
2009-09-04 16:55 ` Stefan Assmann [this message]
2009-09-04 17:07   ` [RFC][PATCH 1/2] show Intel QuickPath Interconnect Routing and Protocol Layer Registers in PCI config space Yinghai Lu
2009-09-05  9:02     ` Stefan Assmann
2009-09-04 16:55 ` [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0 Stefan Assmann
2009-09-04 17:06   ` Daniel Walker
2009-09-05  9:07     ` Stefan Assmann
2009-09-05 14:47       ` Daniel Walker
2009-09-05 16:18         ` Olaf Dabrunz
2009-09-05 17:07           ` Daniel Walker
2009-09-07  1:37             ` Henrique de Moraes Holschuh
2009-09-07  1:53               ` Daniel Walker
2009-09-07  1:33 ` [RFC][PATCH 0/2] " Henrique de Moraes Holschuh
2009-09-07  8:24   ` Stefan Assmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904165535.26294.95511.sendpatchset@t500 \
    --to=sassmann@redhat.com \
    --cc=Olaf.Dabrunz@gmx.net \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=jcm@redhat.com \
    --cc=ktokunag@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sdietrich@novell.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox