Re: [PATCHv2 0/3] tracing - adding common method for reading/parsing user input

Jiri Olsa
2009-09-08T14:37:19Z

On Tue, Sep 08, 2009 at 10:01:39AM -0400, Steven Rostedt wrote:
> On Sat, 2009-09-05 at 03:12 +0200, jolsa@redhat.com wrote:
> > As 3 different places for 4 user input files were using the same way
> > of reading and parsing user's input, I made one common routine to be
> > used.
> >
> > The mentioned files are:
> > set_graph_function
> > set_event
> > set_ftrace_filter
> > set_ftrace_notrace
> >
> > wbr,
> > jirka
> >
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
>
> Looking back, this is pretty much exactly what I did back in February:
>
> http://lkml.org/lkml/2009/2/25/385
>
> The difference is that I wanted this to be a generic feature for things
> outside of tracing to use. I may just take my old patch and put the code
> in trace.c like you did.
>
> Thanks,
>
> -- Steve
>
>

ok, so are you going to take your patch, or should I do the changes you
proposed and send it out again?

wbr,
jirka