From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
"linux-pm" <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Zhang Rui <rui.zhang@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 10 update 2x] PM: Measure suspend and resume times for individual devices
Date: Sun, 6 Sep 2009 14:13:43 +0200 [thread overview]
Message-ID: <200909061413.43683.rjw@sisk.pl> (raw)
In-Reply-To: <20090906044440.GA29963@elte.hu>
On Sunday 06 September 2009, Ingo Molnar wrote:
>
> Thanks Rafael, the code looks a lot more natural IMHO.
>
> this bit:
>
> > +#ifdef DEBUG
> > +static void dbg_get_time(struct timeval *start)
> > +{
> > + do_gettimeofday(start);
> > +}
>
> is a plain wrapper over gettimeofday so you might want to inline
> it. (although GCC will do it too most of the time)
I have a rule of not using 'inline' except for in headers. In this case,
however, it's almost like a header, so I'll follow your suggestion.
Thanks,
Rafael
next prev parent reply other threads:[~2009-09-06 12:13 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 20:17 [PATCH 0/6] PM: Asynchronous suspend and resume of devices Rafael J. Wysocki
2009-08-26 20:20 ` [PATCH 1/6] PM: Introduce PM links framework Rafael J. Wysocki
2009-08-28 15:16 ` Alan Stern
2009-08-28 19:11 ` Rafael J. Wysocki
2009-08-26 20:21 ` [PATCH 2/6] PM: Asynchronous resume of devices Rafael J. Wysocki
2009-08-28 15:43 ` Alan Stern
2009-08-28 19:38 ` Rafael J. Wysocki
2009-08-28 19:59 ` Alan Stern
2009-08-28 22:22 ` Rafael J. Wysocki
2009-08-28 23:20 ` Rafael J. Wysocki
2009-08-29 2:06 ` Alan Stern
2009-08-29 12:49 ` Rafael J. Wysocki
2009-08-29 19:17 ` Rafael J. Wysocki
2009-08-30 0:53 ` Alan Stern
2009-08-30 0:48 ` Alan Stern
2009-08-30 13:15 ` Rafael J. Wysocki
2009-08-30 21:13 ` [PATCH 10] PM: Measure suspend and resume times for individual devices (was: Re: [PATCH 2/6] PM: Asynchronous resume of devices) Rafael J. Wysocki
2009-08-31 7:25 ` Ingo Molnar
2009-08-31 12:53 ` Rafael J. Wysocki
2009-08-31 13:52 ` Ingo Molnar
2009-08-31 15:56 ` Rafael J. Wysocki
2009-08-31 21:32 ` [PATCH 10 update] PM: Measure suspend and resume times for individual devices Rafael J. Wysocki
2009-09-04 7:51 ` [PATCH 10] PM: Measure suspend and resume times for individual devices (was: Re: [PATCH 2/6] PM: Asynchronous resume of devices) Ingo Molnar
2009-09-04 14:42 ` Rafael J. Wysocki
2009-09-04 19:12 ` Ingo Molnar
2009-09-04 21:56 ` [PATCH 10 update 2x] PM: Measure suspend and resume times for individual devices Rafael J. Wysocki
2009-09-06 4:44 ` Ingo Molnar
2009-09-06 12:13 ` Rafael J. Wysocki [this message]
2009-08-31 14:09 ` [PATCH 10] PM: Measure suspend and resume times for individual devices (was: Re: [PATCH 2/6] PM: Asynchronous resume of devices) Alan Stern
2009-08-31 16:00 ` Rafael J. Wysocki
2009-08-30 6:45 ` [PATCH 2/6] PM: Asynchronous resume of devices Pavel Machek
2009-08-30 13:09 ` Rafael J. Wysocki
2009-08-26 20:21 ` [PATCH 3/6] PM: Asynchronous suspend " Rafael J. Wysocki
2009-08-26 20:22 ` [PATCH 4/6] PM: Allow PCI devices to suspend/resume asynchronously Rafael J. Wysocki
2009-08-26 20:23 ` [PATCH 5/6] PM: Allow ACPI " Rafael J. Wysocki
2009-08-26 20:24 ` [PATCH 6/6] PM: Allow serio input " Rafael J. Wysocki
2009-08-27 20:08 ` Dmitry Torokhov
2009-08-27 20:58 ` Rafael J. Wysocki
2009-08-26 22:25 ` [PATCH 0/6] PM: Asynchronous suspend and resume of devices Rafael J. Wysocki
2009-08-27 19:17 ` Rafael J. Wysocki
2009-08-27 19:19 ` [PATCH 7] PM: Add a switch for disabling/enabling asynchronous suspend/resume Rafael J. Wysocki
2009-08-27 20:07 ` Dmitry Torokhov
2009-08-27 22:22 ` [PATCH 7 updated] " Rafael J. Wysocki
2009-08-28 5:22 ` Dmitry Torokhov
2009-08-28 19:42 ` Rafael J. Wysocki
2009-08-27 19:20 ` [PATCH 8] PM: Allow user space to change the power.async_suspend flag of devices Rafael J. Wysocki
2009-08-27 20:04 ` Dmitry Torokhov
2009-08-27 22:24 ` Rafael J. Wysocki
2009-08-28 7:01 ` Pavel Machek
2009-08-29 19:20 ` [PATCH 8 update] " Rafael J. Wysocki
2009-08-27 20:46 ` [PATCH 0/6] PM: Asynchronous suspend and resume " Alan Stern
2009-08-27 21:18 ` Rafael J. Wysocki
2009-08-29 19:22 ` [PATCH 9] PM: Measure device suspend and resume times (was: Re: [PATCH 0/6] PM: Asynchronous suspend and resume of devices) Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909061413.43683.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=arjan@infradead.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox