public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-rt@pengutronix.de,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [RT + staging] buildfailures
Date: Mon, 7 Sep 2009 18:20:29 +0200	[thread overview]
Message-ID: <20090907162029.GA855@pengutronix.de> (raw)
In-Reply-To: <20090622151515.GA16627@pengutronix.de>

Hello,

I just tried to compile 2.6.31-rc8-rt9 on amd64 and got the following
compiler errors in drivers/staging:

 - drivers/staging/comedi:

	  CC [M]  drivers/staging/comedi/drivers/quatech_daqp_cs.o
	drivers/staging/comedi/drivers/quatech_daqp_cs.c: In function ‘daqp_interrupt’:
	drivers/staging/comedi/drivers/quatech_daqp_cs.c:308: error: implicit declaration of function ‘up’
	drivers/staging/comedi/drivers/quatech_daqp_cs.c: In function ‘daqp_ai_insn_read’:
	drivers/staging/comedi/drivers/quatech_daqp_cs.c:421: error: implicit declaration of function ‘sema_init’
	drivers/staging/comedi/drivers/quatech_daqp_cs.c:434: error: implicit declaration of function ‘down_interruptible’

   Possible fix: #include <linux/semaphore.h> in
   drivers/staging/comedi/comedidev.h

 - drivers/staging/rt2870:
	  CC [M]  drivers/staging/rt2870/common/2870_rtmp_init.o
	drivers/staging/rt2870/common/2870_rtmp_init.c: In function ‘CreateThreads’:
	drivers/staging/rt2870/common/2870_rtmp_init.c:754: error: implicit declaration of function ‘semaphore_init_locked’

   with PREEMPT_RT semaphore_init_locked doesn't exist.  The driver
   needs to be converted to use mutexes instead.

   Hhhhm, tglx introduced these in

	041e313 (staging: Bulk convert the semaphore mess)

   !?

   drivers/staging/rt3070/common/2870_rtmp_init.c includes
   ../../rt2870/common/2870_rtmp_init.c, so RT3070 has the same problem.

Just to let you know ...

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

  parent reply	other threads:[~2009-09-07 16:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-13 21:38 [PATCH -rt] disable building all staging drivers Uwe Kleine-König
2009-06-14 11:28 ` Greg KH
2009-06-14 12:34   ` Thomas Gleixner
2009-06-14 23:00   ` Uwe Kleine-König
2009-06-14 23:04     ` Greg KH
2009-06-22 15:15     ` Uwe Kleine-König
2009-06-22 17:19       ` Greg KH
2009-06-22 18:06         ` Daniel Walker
2009-06-22 20:51           ` Greg KH
2009-06-23 11:24         ` Thomas Gleixner
2009-06-23 15:17           ` Greg KH
2009-06-23 15:39             ` Thomas Gleixner
2009-09-07 16:20       ` Uwe Kleine-König [this message]
2009-09-08 18:11         ` [RT + staging] buildfailures Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907162029.GA855@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt@pengutronix.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox