From: Jens Axboe <jens.axboe@oracle.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>
Subject: Re: [PATCH] trace bio queueing trial only when it occurs
Date: Tue, 8 Sep 2009 12:50:36 +0200 [thread overview]
Message-ID: <20090908105036.GT18599@kernel.dk> (raw)
In-Reply-To: <20090908005520.GA7967@localhost>
On Tue, Sep 08 2009, Wu Fengguang wrote:
> Minchan,
>
> I tend to agree with the change, but somehow confused by blkparse(1):
>
> Q -- queued This notes *intent* to queue i/o at the given location. No real requests exists yet.
>
> Li Zefan has been working on blktrace and he can tell more.
The documentation details the original implementation. I'm guessing the
need to move this trace hook is due to some user space tracking that
gets confused, because it cannot match the queue intent with a merge or
an insert.
I have no problems moving the trace call. If we had a matching bio_endio
trace, then I'd say moving it would lose information. But right now it
doesn't.
--
Jens Axboe
next prev parent reply other threads:[~2009-09-08 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 0:34 [PATCH] trace bio queueing trial only when it occurs Minchan Kim
2009-09-08 0:55 ` Wu Fengguang
2009-09-08 2:02 ` Li Zefan
2009-09-08 4:10 ` Minchan Kim
2009-09-08 4:13 ` Wu Fengguang
2009-09-08 4:24 ` Minchan Kim
2009-09-08 10:50 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-07 2:15 Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908105036.GT18599@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).