Re: [RT + staging] buildfailures

[Greg KH <greg@kroah.com>]

On Mon, Sep 07, 2009 at 06:20:29PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> I just tried to compile 2.6.31-rc8-rt9 on amd64 and got the following
> compiler errors in drivers/staging:
> 
>  - drivers/staging/comedi:
> 
> 	  CC [M]  drivers/staging/comedi/drivers/quatech_daqp_cs.o
> 	drivers/staging/comedi/drivers/quatech_daqp_cs.c: In function ‘daqp_interrupt’:
> 	drivers/staging/comedi/drivers/quatech_daqp_cs.c:308: error: implicit declaration of function ‘up’
> 	drivers/staging/comedi/drivers/quatech_daqp_cs.c: In function ‘daqp_ai_insn_read’:
> 	drivers/staging/comedi/drivers/quatech_daqp_cs.c:421: error: implicit declaration of function ‘sema_init’
> 	drivers/staging/comedi/drivers/quatech_daqp_cs.c:434: error: implicit declaration of function ‘down_interruptible’
> 
>    Possible fix: #include <linux/semaphore.h> in
>    drivers/staging/comedi/comedidev.h

Patches welcome :)

>  - drivers/staging/rt2870:
> 	  CC [M]  drivers/staging/rt2870/common/2870_rtmp_init.o
> 	drivers/staging/rt2870/common/2870_rtmp_init.c: In function ‘CreateThreads’:
> 	drivers/staging/rt2870/common/2870_rtmp_init.c:754: error: implicit declaration of function ‘semaphore_init_locked’
> 
>    with PREEMPT_RT semaphore_init_locked doesn't exist.  The driver
>    needs to be converted to use mutexes instead.
> 
>    Hhhhm, tglx introduced these in
> 
> 	041e313 (staging: Bulk convert the semaphore mess)
> 
>    !?
> 
>    drivers/staging/rt3070/common/2870_rtmp_init.c includes
>    ../../rt2870/common/2870_rtmp_init.c, so RT3070 has the same problem.

Then he might want to resolve them, as this code has changed a _lot_ in
the linux-next tree :)

thanks,

greg k-h