Re: [PATCH v3] hwmon driver for ACPI 4.0 power meters

[Pavel Machek <pavel@ucw.cz>]

Hi!

> diff --git a/Documentation/hwmon/acpi_power_meter b/Documentation/hwmon/acpi_power_meter
> new file mode 100644
> index 0000000..b02ddaa
> --- /dev/null
> +++ b/Documentation/hwmon/acpi_power_meter
> @@ -0,0 +1,31 @@
> +Kernel driver power_meter
> +=========================
> +
> +This driver talks to ACPI 4.0 power meters.
> +
> +Supported systems:
> +  * Any recent system with ACPI 4.0.
> +    Prefix: 'power_meter'
> +    Datasheet: http://acpi.info/, section 10.4.
> +
> +Author: Darrick J. Wong
> +
> +Description
> +-----------
> +
> +This driver implements sensor reading support for the power meters exposed in
> +the ACPI 4.0 spec (Chapter 10.4).  These devices have a simple set of
> +features--a power meter that returns average power use over a configurable
> +interval, an optional capping mechanism, and a couple of trip points.

So where do we get the average power?

> +Special Features
> +----------------
> +
> +The power[1-*]_is_battery knob indicates if the power supply is a battery.
> +Both power[1-*]_average_{min,max} must be set before the trip
> points will work.

How do trip points work? It is not explained here.


> +config ACPI_POWER_METER
> +	tristate "ACPI 4.0 power meter"
> +	depends on HWMON
> +	default m

default M is "evil".

> +	  devices.  Say Y (or M) if you have an Intel or AMD computer with
> +	  a power meter.

WTF? Neither Intel nor AMD makes _computers_.

> +	  To compile this driver as a module, choose M here:
> +	  the module will be called power-meter.

.ko.

> +#define POWER_CAP_NAME		"power1_cap"

I did not see power cap explained.

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html