public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Youquan,Song" <youquan.song@intel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Youquan Song <youquan.song@intel.com>,
	mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, dwmw2@infradead.org,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	youqun.song@intel.com
Subject: Re: Fix interrupt remapping hang if interrupt remapping disable in BIOS
Date: Wed, 9 Sep 2009 06:46:06 -0400	[thread overview]
Message-ID: <20090909104606.GA10454@youquan-linux.bj.intel.com> (raw)
In-Reply-To: <20090907145940.GD5294@lenovo>

On Mon, Sep 07, 2009 at 06:59:40PM +0400, Cyrill Gorcunov wrote:
> [Youquan Song - Mon, Sep 07, 2009 at 10:13:13AM -0400]
> ...  
> |  static int disable_intremap;
> |  static __init int setup_nointremap(char *str)
> | @@ -607,9 +608,14 @@ end:
> |  int __init intr_remapping_supported(void)
> |  {
> |  	struct dmar_drhd_unit *drhd;
> | -
> | +	struct acpi_table_dmar *dmar;
> | +
> |  	if (disable_intremap)
> |  		return 0;
> | +
> | +	dmar = (struct acpi_table_dmar *)dmar_tbl;
> | +	if (!(dmar->flags & 0x1))
> | +		return 0;
> |  
> |  	for_each_drhd_unit(drhd) {
> |  		struct intel_iommu *iommu = drhd->iommu;
> 
> Hi Youquan,
> 
> perhaps we could move this test to helper function
> in dmar.c instead of plain external variable test?

Good point. I will update it and send it out soon.

- Youquan



      reply	other threads:[~2009-09-09  3:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 14:13 Fix interrupt remapping hang if interrupt remapping disable in BIOS Youquan Song
2009-09-07 14:59 ` Cyrill Gorcunov
2009-09-09 10:46   ` Youquan,Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090909104606.GA10454@youquan-linux.bj.intel.com \
    --to=youquan.song@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=youqun.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox