From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbZIIPIb (ORCPT ); Wed, 9 Sep 2009 11:08:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753449AbZIIPIA (ORCPT ); Wed, 9 Sep 2009 11:08:00 -0400 Received: from mga14.intel.com ([143.182.124.37]:41520 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440AbZIIPH5 (ORCPT ); Wed, 9 Sep 2009 11:07:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,271,1249282800"; d="scan'208";a="185728209" Message-Id: <20090909150600.451373732@intel.com> References: <20090909145141.293229693@intel.com> User-Agent: quilt/0.46-1 Date: Wed, 09 Sep 2009 22:51:43 +0800 From: Wu Fengguang To: Andrew Morton To: Jens Axboe CC: Dave Chinner CC: Chris Mason CC: Peter Zijlstra CC: Christoph Hellwig CC: jack@suse.cz CC: Artem Bityutskiy Cc: Wu Fengguang , LKML , Subject: [RFC][PATCH 2/7] writeback: fix queue_io() ordering Content-Disposition: inline; filename=queue_io-fix.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This was not a bug, since b_io is empty for kupdate writeback. The next patch will do requeue_io() for non-kupdate writeback, so let's fix it. CC: Dave Chinner Cc: Martin Bligh Cc: Michael Rubin Cc: Peter Zijlstra Signed-off-by: Fengguang Wu --- fs/fs-writeback.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- linux.orig/fs/fs-writeback.c 2009-09-09 21:41:14.000000000 +0800 +++ linux/fs/fs-writeback.c 2009-09-09 21:45:15.000000000 +0800 @@ -313,11 +313,14 @@ static void move_expired_inodes(struct l } /* - * Queue all expired dirty inodes for io, eldest first. + * Queue all expired dirty inodes for io, eldest first: + * (newly dirtied) => b_dirty inodes + * => b_more_io inodes + * => remaining inodes in b_io => (dequeue for sync) */ static void queue_io(struct bdi_writeback *wb, unsigned long *older_than_this) { - list_splice_init(&wb->b_more_io, wb->b_io.prev); + list_splice_init(&wb->b_more_io, &wb->b_io); move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); } --