public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, dhowells@redhat.com,
	roland@redhat.com, jmorris@namei.org, tom.horsley@att.net,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH v3] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex
Date: Thu, 10 Sep 2009 00:58:34 +0200	[thread overview]
Message-ID: <20090909225834.GA14785@redhat.com> (raw)
In-Reply-To: <20090909175749.541b6aa9@dhcp-100-2-144.bos.redhat.com>

On 09/09, Chuck Ebbert wrote:
>
> On Fri, 4 Sep 2009 23:33:37 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > On 09/04, Andrew Morton wrote:
> > >
> > > On Fri, 4 Sep 2009 19:26:48 +0200
> > > Oleg Nesterov <oleg@redhat.com> wrote:
> > >
> > > > Tom Horsley reports that his debugger hangs when it tries to read
> > > > /proc/pid_of_tracee/maps, this happens since
> > > >
> > > > 	"mm_for_maps: take ->cred_guard_mutex to fix the race with exec"
> > > > 	04b836cbf19e885f8366bccb2e4b0474346c02d
> > > >
> > > > commit in 2.6.31.
>
> >
> > > I see a Cc:stable in the mail headers, but not in the changelog.  I
> > > don't think the patch is applicable to -stable unless we miss 2.6.31.
> >
> > -stable has the same problems but I agree, it can live without this fix.
> >
>
> That patch was backported in 2.6.30.5 -- are you sure -stable doesn't need
> this fix?

No, I am not sure, that is why I cc'ed -stable.

But otoh the problem is minor, both tracer and tracee can be killed.

I dunno. I don't know if gdb or any other "important" application
read /proc/pid/maps after PTRACE_EVENT_EXEC...

Oleg.


  reply	other threads:[~2009-09-09 23:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 16:05 [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex Oleg Nesterov
2009-09-03 20:09 ` Roland McGrath
2009-09-04  8:43   ` David Howells
2009-09-04 13:39   ` Oleg Nesterov
2009-09-04 14:47     ` David Howells
2009-09-04 15:49       ` Oleg Nesterov
2009-09-04 17:26         ` [PATCH v3] " Oleg Nesterov
2009-09-04 19:42           ` Andrew Morton
2009-09-04 21:33             ` Oleg Nesterov
2009-09-09 21:57               ` Chuck Ebbert
2009-09-09 22:58                 ` Oleg Nesterov [this message]
2009-09-04  8:39 ` [PATCH 1/1] " David Howells
2009-09-04  9:24   ` Roland McGrath
2009-09-04 12:46   ` Oleg Nesterov
2009-09-04 13:39     ` David Howells
2009-09-04 13:55       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090909225834.GA14785@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cebbert@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=stable@kernel.org \
    --cc=tom.horsley@att.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox