From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Oren Laadan <orenl@cs.columbia.edu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
arnd@arndb.de, container@us.ibm.com, sukadev@us.ibm.com
Subject: [RFC][v6][PATCH 5/9]: Add target_pids parameter to alloc_pid()
Date: Wed, 9 Sep 2009 23:10:16 -0700 [thread overview]
Message-ID: <20090910061016.GD25883@us.ibm.com> (raw)
In-Reply-To: <20090910060627.GA24343@us.ibm.com>
Subject: [RFC][v6][PATCH 5/9]: Add target_pids parameter to alloc_pid()
This parameter is currently NULL, but will be used in a follow-on patch.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Reviewed-by: Oren Laadan <orenl@cs.columbia.edu>
---
include/linux/pid.h | 2 +-
kernel/fork.c | 3 ++-
kernel/pid.c | 9 +++++++--
3 files changed, 10 insertions(+), 4 deletions(-)
Index: linux-2.6/include/linux/pid.h
===================================================================
--- linux-2.6.orig/include/linux/pid.h 2009-09-09 19:06:20.000000000 -0700
+++ linux-2.6/include/linux/pid.h 2009-09-09 19:07:36.000000000 -0700
@@ -119,7 +119,7 @@ extern struct pid *find_get_pid(int nr);
extern struct pid *find_ge_pid(int nr, struct pid_namespace *);
int next_pidmap(struct pid_namespace *pid_ns, int last);
-extern struct pid *alloc_pid(struct pid_namespace *ns);
+extern struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids);
extern void free_pid(struct pid *pid);
/*
Index: linux-2.6/kernel/fork.c
===================================================================
--- linux-2.6.orig/kernel/fork.c 2009-09-09 19:06:46.000000000 -0700
+++ linux-2.6/kernel/fork.c 2009-09-09 19:07:36.000000000 -0700
@@ -940,6 +940,7 @@ static struct task_struct *copy_process(
int retval;
struct task_struct *p;
int cgroup_callbacks_done = 0;
+ pid_t *target_pids = NULL;
if ((clone_flags & (CLONE_NEWNS|CLONE_FS)) == (CLONE_NEWNS|CLONE_FS))
return ERR_PTR(-EINVAL);
@@ -1110,7 +1111,7 @@ static struct task_struct *copy_process(
goto bad_fork_cleanup_io;
if (pid != &init_struct_pid) {
- pid = alloc_pid(p->nsproxy->pid_ns);
+ pid = alloc_pid(p->nsproxy->pid_ns, target_pids);
if (IS_ERR(pid)) {
retval = PTR_ERR(pid);
goto bad_fork_cleanup_io;
Index: linux-2.6/kernel/pid.c
===================================================================
--- linux-2.6.orig/kernel/pid.c 2009-09-09 19:07:28.000000000 -0700
+++ linux-2.6/kernel/pid.c 2009-09-09 19:07:36.000000000 -0700
@@ -268,13 +268,14 @@ void free_pid(struct pid *pid)
call_rcu(&pid->rcu, delayed_put_pid);
}
-struct pid *alloc_pid(struct pid_namespace *ns)
+struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids)
{
struct pid *pid;
enum pid_type type;
int i, nr;
struct pid_namespace *tmp;
struct upid *upid;
+ int tpid;
pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
if (!pid) {
@@ -284,7 +285,11 @@ struct pid *alloc_pid(struct pid_namespa
tmp = ns;
for (i = ns->level; i >= 0; i--) {
- nr = alloc_pidmap(tmp, 0);
+ tpid = 0;
+ if (target_pids)
+ tpid = target_pids[i];
+
+ nr = alloc_pidmap(tmp, tpid);
if (nr < 0)
goto out_free;
next prev parent reply other threads:[~2009-09-10 6:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 6:06 [RFC][v6][PATCH 0/9] clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10 6:08 ` [RFC][v6][PATCH 1/9]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 2/9]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 3/9] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 4/9]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-10 6:10 ` Sukadev Bhattiprolu [this message]
2009-09-10 6:11 ` [RFC][v6][PATCH 6/9]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-10 6:12 ` [RFC][v6][PATCH 7/9]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-10 7:05 ` Arnd Bergmann
2009-09-10 21:29 ` Sukadev Bhattiprolu
2009-09-10 6:13 ` [RFC][v6][PATCH 8/9]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10 7:31 ` Arnd Bergmann
2009-09-10 21:28 ` Sukadev Bhattiprolu
2009-09-11 10:31 ` Arnd Bergmann
2009-09-11 11:00 ` Louis Rilling
2009-09-11 11:12 ` Arnd Bergmann
2009-09-10 6:14 ` [RFC][v6][PATCH 9/9]: Document " Sukadev Bhattiprolu
2009-09-10 15:26 ` Randy Dunlap
2009-09-10 16:31 ` Sukadev Bhattiprolu
2009-09-11 11:22 ` [RFC][v6][PATCH 0/9] " Peter Zijlstra
2009-09-11 11:34 ` Arnd Bergmann
2009-09-11 11:40 ` Peter Zijlstra
2009-09-11 11:50 ` Arnd Bergmann
2009-09-11 16:47 ` Sukadev Bhattiprolu
2009-09-11 17:00 ` Peter Zijlstra
2009-09-12 17:19 ` Sukadev Bhattiprolu
2009-09-13 14:36 ` Arnd Bergmann
2009-09-14 7:14 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910061016.GD25883@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=container@us.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mingo@elte.hu \
--cc=nathanl@austin.ibm.com \
--cc=orenl@cs.columbia.edu \
--cc=sukadev@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox