public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, Oren Laadan <orenl@cs.columbia.edu>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
	torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
	hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
	container@us.ibm.com, sukadev@us.ibm.com
Subject: Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall
Date: Fri, 11 Sep 2009 13:50:14 +0200	[thread overview]
Message-ID: <200909111350.15004.arnd@arndb.de> (raw)
In-Reply-To: <1252669205.7126.23.camel@laptop>

On Friday 11 September 2009, Peter Zijlstra wrote:
> On Fri, 2009-09-11 at 13:34 +0200, Arnd Bergmann wrote:
> > On Friday 11 September 2009, Peter Zijlstra wrote:
> 
> > > If you then get passed a longer clone_struct than you know about, all is
> > > well IFF the tail is 0, otherwise fail with -E2BIG.
> > > 
> > > If you get passed a short clone_struct, zero out the tail.
> > 
> > I would leave out the size argument. We can put a few reserved fields
> > and flag bits in there for possible extensions, but if we ever run out
> > of these, just define a new syscall.
> 
> Why? If we can avoid this new syscall isn't that nicer?

There is a limit to how much flexibility I would aim for. In the last
fourty years, we needed three revisions of that call (fork, clone,
clone2). By invalid extrapolation, adding room for another extension
should give us at least twenty years ;-)

Also, the flags field basically has the same purpose are the size field,
so we do not need both. In the worst case, you can define one of the
flags to mean 'the structure is now 168 bytes long'.

	Arnd <><

  reply	other threads:[~2009-09-11 11:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10  6:06 [RFC][v6][PATCH 0/9] clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10  6:08 ` [RFC][v6][PATCH 1/9]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-10  6:09 ` [RFC][v6][PATCH 2/9]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-10  6:09 ` [RFC][v6][PATCH 3/9] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-10  6:09 ` [RFC][v6][PATCH 4/9]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-10  6:10 ` [RFC][v6][PATCH 5/9]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-10  6:11 ` [RFC][v6][PATCH 6/9]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-10  6:12 ` [RFC][v6][PATCH 7/9]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-10  7:05   ` Arnd Bergmann
2009-09-10 21:29     ` Sukadev Bhattiprolu
2009-09-10  6:13 ` [RFC][v6][PATCH 8/9]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10  7:31   ` Arnd Bergmann
2009-09-10 21:28     ` Sukadev Bhattiprolu
2009-09-11 10:31       ` Arnd Bergmann
2009-09-11 11:00         ` Louis Rilling
2009-09-11 11:12           ` Arnd Bergmann
2009-09-10  6:14 ` [RFC][v6][PATCH 9/9]: Document " Sukadev Bhattiprolu
2009-09-10 15:26   ` Randy Dunlap
2009-09-10 16:31     ` Sukadev Bhattiprolu
2009-09-11 11:22 ` [RFC][v6][PATCH 0/9] " Peter Zijlstra
2009-09-11 11:34   ` Arnd Bergmann
2009-09-11 11:40     ` Peter Zijlstra
2009-09-11 11:50       ` Arnd Bergmann [this message]
2009-09-11 16:47     ` Sukadev Bhattiprolu
2009-09-11 17:00       ` Peter Zijlstra
2009-09-12 17:19         ` Sukadev Bhattiprolu
2009-09-13 14:36           ` Arnd Bergmann
2009-09-14  7:14           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909111350.15004.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=container@us.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=nathanl@austin.ibm.com \
    --cc=orenl@cs.columbia.edu \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=sukadev@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox