From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH 04/10] s390: Convert BUG() to use unreachable()
Date: Fri, 11 Sep 2009 14:18:24 +0200 [thread overview]
Message-ID: <20090911141824.2c7ce579@skybase> (raw)
In-Reply-To: <1252627011-2933-4-git-send-email-ddaney@caviumnetworks.com>
On Thu, 10 Sep 2009 16:56:45 -0700
David Daney <ddaney@caviumnetworks.com> wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
> CC: Heiko Carstens <heiko.carstens@de.ibm.com>
> CC: linux390@de.ibm.com
> CC: linux-s390@vger.kernel.org
> ---
> arch/s390/include/asm/bug.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
> index 7efd0ab..efb74fd 100644
> --- a/arch/s390/include/asm/bug.h
> +++ b/arch/s390/include/asm/bug.h
> @@ -49,7 +49,7 @@
>
> #define BUG() do { \
> __EMIT_BUG(0); \
> - for (;;); \
> + unreachable(); \
> } while (0)
>
> #define WARN_ON(x) ({ \
That seems simple enough ;-)
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2009-09-11 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AA991C1.1050800@caviumnetworks.com>
2009-09-10 23:56 ` [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h David Daney
2009-09-11 0:14 ` Richard Henderson
2009-09-11 14:32 ` Michael Buesch
2009-09-11 15:58 ` David Daney
2009-09-12 7:22 ` Geert Uytterhoeven
2009-09-14 15:40 ` David Daney
2009-09-10 23:56 ` [PATCH 02/10] x86: Convert BUG() to use unreachable() David Daney
2009-09-11 0:56 ` H. Peter Anvin
2009-09-11 1:09 ` Roland McGrath
2009-09-11 1:13 ` Linus Torvalds
2009-09-11 1:33 ` H. Peter Anvin
2009-09-11 1:37 ` Roland McGrath
2009-09-11 1:42 ` H. Peter Anvin
2009-09-11 6:07 ` Ingo Molnar
2009-09-11 15:55 ` David Daney
2009-09-13 20:12 ` H. Peter Anvin
2009-09-10 23:56 ` [PATCH 03/10] MIPS: " David Daney
2009-09-10 23:56 ` [PATCH 04/10] s390: " David Daney
2009-09-11 12:18 ` Martin Schwidefsky [this message]
2009-09-10 23:56 ` [PATCH 05/10] mn10300: " David Daney
2009-09-10 23:56 ` [PATCH 06/10] parisc: " David Daney
2009-09-28 3:20 ` Kyle McMartin
2009-09-10 23:56 ` [PATCH 07/10] powerpc: " David Daney
2009-09-10 23:56 ` [PATCH 08/10] alpha: " David Daney
2009-09-10 23:56 ` [PATCH 09/10] avr32: " David Daney
2009-09-11 7:31 ` Haavard Skinnemoen
2009-09-10 23:56 ` [PATCH 10/10] blackfin: " David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911141824.2c7ce579@skybase \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ddaney@caviumnetworks.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox