public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] [13/21] HWPOISON: Define a new error_remove_page address space op for async truncation
Date: Fri, 11 Sep 2009 20:48:42 +0200 (CEST)	[thread overview]
Message-ID: <20090911184842.2F5EFB1757@basil.firstfloor.org> (raw)
In-Reply-To: <20090911848.933193846@firstfloor.org>


Truncating metadata pages is not safe right now before
we haven't audited all file systems.

To enable truncation only for data address space define
a new address_space callback error_remove_page.

This is used for memory_failure.c memory error handling.

This can be then set to truncate_inode_page()

This patch just defines the new operation and adds documentation.

Callers and users come in followon patches.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 Documentation/filesystems/vfs.txt |    7 +++++++
 include/linux/fs.h                |    1 +
 include/linux/mm.h                |    1 +
 mm/truncate.c                     |   17 +++++++++++++++++
 4 files changed, 26 insertions(+)

Index: linux/include/linux/fs.h
===================================================================
--- linux.orig/include/linux/fs.h
+++ linux/include/linux/fs.h
@@ -595,6 +595,7 @@ struct address_space_operations {
 	int (*launder_page) (struct page *);
 	int (*is_partially_uptodate) (struct page *, read_descriptor_t *,
 					unsigned long);
+	int (*error_remove_page)(struct address_space *, struct page *);
 };
 
 /*
Index: linux/Documentation/filesystems/vfs.txt
===================================================================
--- linux.orig/Documentation/filesystems/vfs.txt
+++ linux/Documentation/filesystems/vfs.txt
@@ -536,6 +536,7 @@ struct address_space_operations {
 	/* migrate the contents of a page to the specified target */
 	int (*migratepage) (struct page *, struct page *);
 	int (*launder_page) (struct page *);
+	int (*error_remove_page) (struct mapping *mapping, struct page *page);
 };
 
   writepage: called by the VM to write a dirty page to backing store.
@@ -694,6 +695,12 @@ struct address_space_operations {
   	prevent redirtying the page, it is kept locked during the whole
 	operation.
 
+  error_remove_page: normally set to generic_error_remove_page if truncation
+	is ok for this address space. Used for memory failure handling.
+	Setting this implies you deal with pages going away under you,
+	unless you have them locked or reference counts increased.
+
+
 The File Object
 ===============
 
Index: linux/mm/truncate.c
===================================================================
--- linux.orig/mm/truncate.c
+++ linux/mm/truncate.c
@@ -147,6 +147,23 @@ int truncate_inode_page(struct address_s
 }
 
 /*
+ * Used to get rid of pages on hardware memory corruption.
+ */
+int generic_error_remove_page(struct address_space *mapping, struct page *page)
+{
+	if (!mapping)
+		return -EINVAL;
+	/*
+	 * Only punch for normal data pages for now.
+	 * Handling other types like directories would need more auditing.
+	 */
+	if (!S_ISREG(mapping->host->i_mode))
+		return -EIO;
+	return truncate_inode_page(mapping, page);
+}
+EXPORT_SYMBOL(generic_error_remove_page);
+
+/*
  * Safely invalidate one page from its pagecache mapping.
  * It only drops clean, unused pages. The page must be locked.
  *
Index: linux/include/linux/mm.h
===================================================================
--- linux.orig/include/linux/mm.h
+++ linux/include/linux/mm.h
@@ -795,6 +795,7 @@ extern int vmtruncate(struct inode * ino
 extern int vmtruncate_range(struct inode * inode, loff_t offset, loff_t end);
 
 int truncate_inode_page(struct address_space *mapping, struct page *page);
+int generic_error_remove_page(struct address_space *mapping, struct page *page);
 
 int invalidate_inode_page(struct page *page);
 

  parent reply	other threads:[~2009-09-11 18:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 18:48 [PATCH] [0/21] HWPOISON: Intro Andi Kleen
2009-09-11 18:48 ` [PATCH] [1/21] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-09-11 18:48 ` [PATCH] [2/21] HWPOISON: Export some rmap vma locking to outside world Andi Kleen
2009-09-11 18:48 ` [PATCH] [3/21] HWPOISON: Add support for poison swap entries v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [4/21] HWPOISON: Add new SIGBUS error codes for hardware poison signals Andi Kleen
2009-09-11 18:48 ` [PATCH] [5/21] HWPOISON: Add basic support for poisoned pages in fault handler v3 Andi Kleen
2009-09-11 18:48 ` [PATCH] [6/21] HWPOISON: Add various poison checks in mm/memory.c v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [7/21] HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handler v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [8/21] HWPOISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-09-11 18:48 ` [PATCH] [9/21] HWPOISON: Handle hardware poisoned pages in try_to_unmap Andi Kleen
2009-09-11 18:48 ` [PATCH] [10/21] HWPOISON: check and isolate corrupted free pages v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [11/21] HWPOISON: Refactor truncate to allow direct truncating of page v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [12/21] HWPOISON: Add invalidate_inode_page Andi Kleen
2009-09-11 18:48 ` Andi Kleen [this message]
2009-09-11 18:48 ` [PATCH] [14/21] HWPOISON: shmem: call set_page_dirty() with locked page Andi Kleen
2009-09-11 20:24   ` Peter Zijlstra
2009-09-11 21:56     ` Andi Kleen
2009-09-11 18:48 ` [PATCH] [15/21] HWPOISON: Add PR_MCE_KILL prctl to control early kill behaviour per process Andi Kleen
2009-09-11 18:48 ` [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7 Andi Kleen
2009-09-11 19:25   ` Daniel Walker
2009-09-11 19:33     ` Andi Kleen
2009-09-11 19:38       ` Daniel Walker
2009-09-11 20:58       ` Daniel Walker
2009-09-11 21:57         ` Andi Kleen
2009-09-11 22:01           ` Daniel Walker
2009-09-11 18:48 ` [PATCH] [17/21] HWPOISON: Enable .remove_error_page for migration aware file systems Andi Kleen
2009-09-11 18:48 ` [PATCH] [18/21] HWPOISON: Enable error_remove_page for NFS Andi Kleen
2009-09-11 18:48 ` [PATCH] [19/21] HWPOISON: Add madvise() based injector for hardware poisoned pages v4 Andi Kleen
2009-09-11 18:48 ` [PATCH] [20/21] HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNs Andi Kleen
2009-09-11 18:48 ` [PATCH] [21/21] HWPOISON: Enable error_remove_page on btrfs Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090911184842.2F5EFB1757@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox