public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Theodore Tso <tytso@mit.edu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
	Sam Ravnborg <sam@ravnborg.org>,
	Dick Streefland <dick@streefland.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH 15/15] kconfig: add missing dependency of conf to localyesconfig
Date: Fri, 11 Sep 2009 15:59:04 -0400	[thread overview]
Message-ID: <20090911200036.694094308@goodmis.org> (raw)
In-Reply-To: 20090911195849.451244684@goodmis.org

[-- Attachment #1: 0015-kconfig-add-missing-dependency-of-conf-to-localyesco.patch --]
[-- Type: text/plain, Size: 1335 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

There's a dependency missing.

$ make localyesconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/docproc
  HOSTCC  scripts/basic/hash
using config: '/boot/config-2.6.27.25-78.2.56.fc9.x86_64'
/bin/sh: line 8: scripts/kconfig/conf: No such file or directory
make[1]: *** [localyesconfig] Error 127
make: *** [localyesconfig] Error 2

Thus the script failed to run. But the sed command that converts the '=m'
to '=y' still ran. This gives us a distro config with all modules
converted to built in!

The missing dependency was for conf for localyesconfig. This
dependency was already set for localmodconfig.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 scripts/kconfig/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 915a39a..6d69c7c 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -43,7 +43,7 @@ localmodconfig: $(obj)/streamline_config.pl $(obj)/conf
 	fi
 	$(Q)rm -f .tmp.config
 
-localyesconfig: $(obj)/streamline_config.pl
+localyesconfig: $(obj)/streamline_config.pl $(obj)/conf
 	$(Q)perl $< $(Kconfig) > .tmp.config
 	$(Q)sed -i s/=m/=y/ .tmp.config
 	$(Q)if [ -f .config ]; then 				\
-- 
1.6.3.3

-- 

      parent reply	other threads:[~2009-09-11 20:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 19:58 [PATCH 00/15] [GIT PULL] kconfig: localmodconfig for v2.6.32 Steven Rostedt
2009-09-11 19:58 ` [PATCH 01/15] kconfig: add streamline_config.pl to scripts Steven Rostedt
2009-09-11 19:58 ` [PATCH 02/15] kconfig: make localmodconfig to run streamline_config.pl Steven Rostedt
2009-09-11 19:58 ` [PATCH 03/15] kconfig: add make localyesconfig option Steven Rostedt
2009-09-11 19:58 ` [PATCH 04/15] kconfig: streamline_config.pl do not stop with no depends Steven Rostedt
2009-09-11 19:58 ` [PATCH 05/15] kconfig: do not warn about modules built in Steven Rostedt
2009-09-11 19:58 ` [PATCH 06/15] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl Steven Rostedt
2009-09-11 19:58 ` [PATCH 07/15] kconfig: add check if end exists in extract-ikconfig Steven Rostedt
2009-09-11 19:58 ` [PATCH 08/15] kconfig: have extract-ikconfig read ELF files Steven Rostedt
2009-09-11 19:58 ` [PATCH 09/15] kconfig: keep config.gz around even if CONFIG_IKCONFIG_PROC is not set Steven Rostedt
2009-09-11 19:58 ` [PATCH 10/15] kconfig: search for a config to base the local(mod|yes)config on Steven Rostedt
2009-09-11 19:59 ` [PATCH 11/15] kconfig: unset IKCONFIG_PROC and clean up nesting Steven Rostedt
2009-09-11 19:59 ` [PATCH 12/15] kconfig: test for /boot/config-uname after /proc/config.gz in localconfig Steven Rostedt
2009-09-11 19:59 ` [PATCH 13/15] kconfig: make local .config default for streamline_config Steven Rostedt
2009-09-11 19:59 ` [PATCH 14/15] kconfig: test if a .config already exists Steven Rostedt
2009-09-11 19:59 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090911200036.694094308@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dick@streefland.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox