From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: Re: [RFC][PATCH 1/2] pin kern mounts as writable
Date: Sat, 12 Sep 2009 14:42:11 +0100 [thread overview]
Message-ID: <20090912134211.GC5858@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090803215940.DF984602@kernel>
On Mon, Aug 03, 2009 at 02:59:40PM -0700, Dave Hansen wrote:
> If we are going to continue to use mnt_clone_write() inside
> of init_file(), then we're going to need some kind of extra
> handling.
>
> What I want to do in the next patch is add a debugging check
> in mnt_clone_write() to double-check that there *is* a real
> writer on the mount before mnt_clone_write() succeeds. To
> do that, we either need to check for MS_KERNMOUNT around
> that debug check, or we need to make sure that these kern
> mounts *have* a write already.
>
> I'm choosing to make sure they always have a write.
> + err = mnt_want_write(mnt);
> + WARN_ON(err);
And what would happen to that when we do it to a filesystem that is
made read-only by its ->get_sb()?
prev parent reply other threads:[~2009-09-12 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 21:59 [RFC][PATCH 1/2] pin kern mounts as writable Dave Hansen
2009-08-03 21:59 ` [RFC][PATCH 2/2] fix mnt_want_write_file() on special files Dave Hansen
2009-09-12 13:42 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912134211.GC5858@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dave@linux.vnet.ibm.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox