From: Jens Axboe <jens.axboe@oracle.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: recent bdi changes result in WARN_ON on luksClose / dm
Date: Sat, 12 Sep 2009 21:52:12 +0200 [thread overview]
Message-ID: <20090912195212.GF14984@kernel.dk> (raw)
In-Reply-To: <20090912111928.GA8013@Chamillionaire.breakpoint.cc>
On Sat, Sep 12 2009, Sebastian Andrzej Siewior wrote:
> | Orion:/# cryptsetup luksClose crypto
> |------------[ cut here ]------------
> |WARNING: at /home/bigeasy/git/cryptodev-2.6/mm/backing-dev.c:637 bdi_destroy+0x44/0x60()
> |Modules linked in: cbc sha256_generic dm_crypt [last unloaded: mv_cesa]
> |[<c0028dd8>] (unwind_backtrace+0x0/0xdc) from [<c003adb0>] (warn_slowpath_common+0x4c/0x80)
> |[<c003adb0>] (warn_slowpath_common+0x4c/0x80) from [<c007f2e0>] (bdi_destroy+0x44/0x60)
> |[<c007f2e0>] (bdi_destroy+0x44/0x60) from [<c012e3a0>] (blk_release_queue+0x3c/0x54)
> |[<c012e3a0>] (blk_release_queue+0x3c/0x54) from [<c01399a8>] (kobject_release+0x5c/0x74)
> |[<c01399a8>] (kobject_release+0x5c/0x74) from [<c013a6ac>] (kref_put+0x68/0x7c)
> |[<c013a6ac>] (kref_put+0x68/0x7c) from [<c01b7098>] (dm_put+0x148/0x178)
> |[<c01b7098>] (dm_put+0x148/0x178) from [<c01bb82c>] (dev_remove+0x98/0xb4)
> |[<c01bb82c>] (dev_remove+0x98/0xb4) from [<c01bbec0>] (dm_ctl_ioctl+0x21c/0x29c)
> |[<c01bbec0>] (dm_ctl_ioctl+0x21c/0x29c) from [<c00a153c>] (vfs_ioctl+0x2c/0x8c)
> |[<c00a153c>] (vfs_ioctl+0x2c/0x8c) from [<c00a1bac>] (do_vfs_ioctl+0x524/0x590)
> |[<c00a1bac>] (do_vfs_ioctl+0x524/0x590) from [<c00a1c50>] (sys_ioctl+0x38/0x5c)
> |[<c00a1c50>] (sys_ioctl+0x38/0x5c) from [<c0023e80>] (ret_fast_syscall+0x0/0x2c)
> |---[ end trace b3c544a14b51605c ]---
So dm is killing the queue and associated backing device, while dirty
inodes still exist. That's not very nice. Perhaps dm_lock_for_deletion()
should ensure that the backing is flushed?
--
Jens Axboe
next prev parent reply other threads:[~2009-09-12 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 11:19 recent bdi changes result in WARN_ON on luksClose / dm Sebastian Andrzej Siewior
2009-09-12 19:52 ` Jens Axboe [this message]
2009-09-12 19:58 ` Jens Axboe
2009-09-12 20:07 ` Jens Axboe
2009-09-13 9:13 ` Sebastian Andrzej Siewior
2009-09-13 17:57 ` Jens Axboe
2009-09-14 9:05 ` Jens Axboe
2009-09-14 12:27 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912195212.GF14984@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox