From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Maciej Sosnowski <maciej.sosnowski@intel.com>,
linux-kernel@vger.kernel.org
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: dca: module load should not be an error message
Date: Sun, 13 Sep 2009 09:07:37 -0700 [thread overview]
Message-ID: <20090913090737.3141c842@nehalam> (raw)
The message (if it must exist) should not be an error message.
IMHO such messages are useless.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
I sent patch for this previously, but it seems to have been ignored.
--- a/drivers/dca/dca-core.c 2009-09-13 09:02:25.896005620 -0700
+++ b/drivers/dca/dca-core.c 2009-09-13 09:02:50.786144428 -0700
@@ -276,7 +276,7 @@ EXPORT_SYMBOL_GPL(dca_unregister_notify)
static int __init dca_init(void)
{
- printk(KERN_ERR "dca service started, version %s\n", DCA_VERSION);
+ pr_info("dca service started, version %s\n", DCA_VERSION);
return dca_sysfs_init();
}
next reply other threads:[~2009-09-13 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 16:07 Stephen Hemminger [this message]
2009-09-13 17:31 ` dca: module load should not be an error message Dan Williams
2009-09-14 15:08 ` Sosnowski, Maciej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913090737.3141c842@nehalam \
--to=shemminger@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox