Re: [patch] Re: newer version of HTC Dream support

Randy Dunlap
2009-09-14T19:56:28Z

On Mon, 14 Sep 2009 09:11:36 +0200 Pavel Machek wrote:

> Hi!
>
> > > #obj-y += audio_out.o audio_in.o audio_mp3.o audmgr.o audpp.o
> > > #obj-y += snd.o
> > >
> > > from build, the rest should now build ok.
> >
> > but still not link?
> >
> > drivers/staging/dream/camera/msm_camera.c:1482: undefined reference to `msm_camera_flash_set_led_state'
> >
> > CONFIG_MSM_CAMERA_FLASH=y
>
> It should link with the patch below...

Ack. All built now. Thanks.

> ---
>
> HTC Dream hardware has no camera flash, and current arm/mach-msm does
> not have flash support. Disable flash support for now.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/staging/dream/camera/Kconfig b/drivers/staging/dream/camera/Kconfig
> index 0a3e903..bfb6d24 100644
> --- a/drivers/staging/dream/camera/Kconfig
> +++ b/drivers/staging/dream/camera/Kconfig
> @@ -15,7 +15,7 @@ config MSM_CAMERA_DEBUG
>
> config MSM_CAMERA_FLASH
> bool "Qualcomm MSM camera flash support"
> - depends on MSM_CAMERA
> + depends on MSM_CAMERA && BROKEN
> ---help---
> Enable support for LED flash for msm camera
>
>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon