Re: [PATCH v4] input/keyboard: new OpenCores Keyboard Controller driver

Dmitry Torokhov
2009-09-16T03:45:58Z

Hi Mike,

On Tue, Sep 15, 2009 at 10:00:40PM -0400, Mike Frysinger wrote:
> +
> +static int __devexit opencores_kbd_remove(struct platform_device *pdev)
> +{
> + struct opencores_kbd *opencores_kbd = platform_get_drvdata(pdev);
> +
> + free_irq(opencores_kbd->irq, opencores_kbd);
> +
> + input_unregister_device(opencores_kbd->input);
> + kfree(opencores_kbd);

You need to do iounmap and free the memory region here as well.
> +
> + platform_set_drvdata(pdev, NULL);
> +
> + return 0;
> +}
> +

--
Dmitry