Re: [PATCH v3] input/keyboard: new OpenCores Keyboard Controller driver

Dmitry Torokhov
2009-09-14T17:49:58Z

Hi Mike,

On Monday 14 September 2009 10:40:03 am Mike Frysinger wrote:
> +
> +struct opencores_kbd {
> + struct input_dev *input;
> + struct resource *addr_res;
> + struct resource *irq_res;
> + unsigned short *keycode;
> +};

Why do we allocate keycode table separately form the main structure?

I think I still have some reservations with the notion that we can just
have exact "scancode" - KEY_* mapping and hardware producers will adjust
the hardware to follow the deriver but I guess it's OK...

--
Dmitry