From: Andrew Morton <akpm@linux-foundation.org>
To: Nitin Gupta <ngupta@vflare.org>
Cc: justinmattock@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [mmotm] change "getline" to "get_line" to avoid C library confusion
Date: Mon, 14 Sep 2009 15:24:27 -0700 [thread overview]
Message-ID: <20090914152427.71d1fa93.akpm@linux-foundation.org> (raw)
In-Reply-To: <d760cf2d0909132059j9852955s429be24aea1722ee@mail.gmail.com>
On Mon, 14 Sep 2009 09:29:30 +0530
Nitin Gupta <ngupta@vflare.org> wrote:
> Reintroduce this change to fix compilation error on mmotm.
> (Original change by Justin P. Mattock)
>
> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> ---
> scripts/unifdef.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> index 552025e..05a31a6 100644
> --- a/scripts/unifdef.c
> +++ b/scripts/unifdef.c
> @@ -206,7 +206,7 @@ static void done(void);
> static void error(const char *);
> static int findsym(const char *);
> static void flushline(bool);
> -static Linetype getline(void);
> +static Linetype get_line(void);
> static Linetype ifeval(const char **);
> static void ignoreoff(void);
> static void ignoreon(void);
> @@ -512,7 +512,7 @@ process(void)
>
> for (;;) {
> linenum++;
> - lineval = getline();
> + lineval = get_line();
> trans_table[ifstate[depth]][lineval]();
> debug("process %s -> %s depth %d",
> linetype_name[lineval],
> @@ -526,7 +526,7 @@ process(void)
> * help from skipcomment().
> */
> static Linetype
> -getline(void)
> +get_line(void)
> {
> const char *cp;
I'm all confused again. This:
commit d15bd1067b1fcb2b7250d22bc0c7c7fea0b759f7
Author: Justin P. Mattock <justinmattock@gmail.com>
AuthorDate: Sat Mar 7 13:31:29 2009 +0100
Commit: Sam Ravnborg <sam@ravnborg.org>
CommitDate: Sat Mar 7 13:31:29 2009 +0100
kbuild: fix C libary confusion in unifdef.c due to getline()
went into mainline months ago and afaict nothing has subsequently
changed in that area?
next prev parent reply other threads:[~2009-09-14 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 3:59 [PATCH] [mmotm] change "getline" to "get_line" to avoid C library confusion Nitin Gupta
2009-09-14 22:24 ` Andrew Morton [this message]
2009-09-15 2:57 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914152427.71d1fa93.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox