From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sam@ravnborg.org
Subject: [PATCH] [2/5] kbuild: Check if linker supports the -X option
Date: Mon, 14 Sep 2009 22:18:07 +0200 (CEST) [thread overview]
Message-ID: <20090914201807.F1214B1757@basil.firstfloor.org> (raw)
In-Reply-To: <200909141018.915641783@firstfloor.org>
The new alternative `gold' linker in recent binutils doesn't support
the -X option. This breaks allyesconfig builds that have
CONFIG_STRIP_ASM_SYMS enabled. Check if the linker really supports
the option using ld-option.
This requires fixes in earlier patches.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.31-rc1-ak/Makefile
===================================================================
--- linux-2.6.31-rc1-ak.orig/Makefile
+++ linux-2.6.31-rc1-ak/Makefile
@@ -599,7 +599,7 @@ LDFLAGS_MODULE += $(LDFLAGS_BUILD_ID)
LDFLAGS_vmlinux += $(LDFLAGS_BUILD_ID)
ifeq ($(CONFIG_STRIP_ASM_SYMS),y)
-LDFLAGS_vmlinux += -X
+LDFLAGS_vmlinux += $(call ld-option, -X,)
endif
# Default kernel image to build when no specific target is given.
next prev parent reply other threads:[~2009-09-14 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 20:18 [PATCH] [0/5] kbuild: A couple of Kbuild fixes/improvements Andi Kleen
2009-09-14 20:18 ` [PATCH] [1/5] kbuild: Fix ld-option Makefile macro to really work Andi Kleen
2009-09-14 21:47 ` Sam Ravnborg
2009-09-15 13:01 ` Andi Kleen
2009-09-15 15:32 ` Sam Ravnborg
2009-09-14 20:18 ` Andi Kleen [this message]
2009-09-14 20:18 ` [PATCH] [3/5] kbuild: Echo the record_mcount command Andi Kleen
2009-09-14 20:18 ` [PATCH] [4/5] kbuild: Fail build if recordmcount.pl fails Andi Kleen
2009-09-14 20:18 ` [PATCH] [5/5] kbuild: Set -fconserve-stack option for gcc 4.5 Andi Kleen
2009-09-14 21:36 ` Andrew Morton
2009-09-19 9:20 ` Sam Ravnborg
2009-09-20 12:04 ` Andi Kleen
2009-09-14 21:43 ` [PATCH] [0/5] kbuild: A couple of Kbuild fixes/improvements Sam Ravnborg
2009-09-14 21:47 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2009-08-05 21:51 Andi Kleen
2009-08-05 21:51 ` [PATCH] [2/5] kbuild: Check if linker supports the -X option Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914201807.F1214B1757@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox