From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] [1/5] kbuild: Fix ld-option Makefile macro to really work
Date: Tue, 15 Sep 2009 15:01:47 +0200 [thread overview]
Message-ID: <20090915130146.GA12351@basil.fritz.box> (raw)
In-Reply-To: <20090914214711.GB7990@merkur.ravnborg.org>
> So now we pass the option direct to the linker rather than via gcc -wl.
> I assume this breaks the other 8 uses of ld-option in the kernel?
>
> Or does ld understand the -wl,... syntax?
It does not. But -X is passed directly to the linker, not via gcc,
so it needs to probe ld directly
The right fix is probably an new macro that works with ld (and
ideally rename this one which is confusingly named) I'll
send an updated patch.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-09-15 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 20:18 [PATCH] [0/5] kbuild: A couple of Kbuild fixes/improvements Andi Kleen
2009-09-14 20:18 ` [PATCH] [1/5] kbuild: Fix ld-option Makefile macro to really work Andi Kleen
2009-09-14 21:47 ` Sam Ravnborg
2009-09-15 13:01 ` Andi Kleen [this message]
2009-09-15 15:32 ` Sam Ravnborg
2009-09-14 20:18 ` [PATCH] [2/5] kbuild: Check if linker supports the -X option Andi Kleen
2009-09-14 20:18 ` [PATCH] [3/5] kbuild: Echo the record_mcount command Andi Kleen
2009-09-14 20:18 ` [PATCH] [4/5] kbuild: Fail build if recordmcount.pl fails Andi Kleen
2009-09-14 20:18 ` [PATCH] [5/5] kbuild: Set -fconserve-stack option for gcc 4.5 Andi Kleen
2009-09-14 21:36 ` Andrew Morton
2009-09-19 9:20 ` Sam Ravnborg
2009-09-20 12:04 ` Andi Kleen
2009-09-14 21:43 ` [PATCH] [0/5] kbuild: A couple of Kbuild fixes/improvements Sam Ravnborg
2009-09-14 21:47 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2009-08-05 21:51 Andi Kleen
2009-08-05 21:51 ` [PATCH] [1/5] kbuild: Fix ld-option Makefile macro to really work Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915130146.GA12351@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox