linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	x86 <x86@kernel.org>, Doug Thompson <norsk5@yahoo.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [origin tree build failure] [PATCH] Fix: amd64_edac.c:(.text+0x3e9491): undefined reference to `amd_decode_nb_mce'
Date: Tue, 15 Sep 2009 15:25:49 +0200	[thread overview]
Message-ID: <20090915132549.GA3824@aftab> (raw)
In-Reply-To: <20090915115935.GA24391@elte.hu>

On Tue, Sep 15, 2009 at 01:59:35PM +0200, Ingo Molnar wrote:
> 
> -tip testing found the following build failure (config attached):
> 
> drivers/built-in.o: In function `amd64_check':
> amd64_edac.c:(.text+0x3e9491): undefined reference to `amd_decode_nb_mce'
> drivers/built-in.o: In function `amd64_init_2nd_stage':
> amd64_edac.c:(.text+0x3e9b46): undefined reference to `amd_report_gart_errors'
> amd64_edac.c:(.text+0x3e9b55): undefined reference to `amd_register_ecc_decoder'
> drivers/built-in.o: In function `amd64_nbea_store':
> amd64_edac_dbg.c:(.text+0x3ea22e): undefined reference to `amd_decode_nb_mce'
> drivers/built-in.o: In function `amd64_remove_one_instance':
> amd64_edac.c:(.devexit.text+0x3eea): undefined reference to `amd_report_gart_errors'
> amd64_edac.c:(.devexit.text+0x3ef6): undefined reference to `amd_unregister_ecc_decoder'
> 
> the AMD EDAC code has a dependency on CONFIG_CPU_SUP_AMD facilities. The 
> patch below solves the problem here.

Dang(!), thanks for catching that one. Will add it to the lineup of the
next pull request to Linus.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632


      reply	other threads:[~2009-09-15 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 17:19 [GIT PULL] AMD64 EDAC updates, p1 Borislav Petkov
2009-09-15 11:09 ` [origin tree build failure] " Ingo Molnar
2009-09-15 13:29   ` Borislav Petkov
2009-09-15 14:38   ` Jean Delvare
2009-09-15 14:59     ` Borislav Petkov
2009-09-16  9:41       ` Américo Wang
2009-09-15 11:59 ` [origin tree build failure] [PATCH] Fix: amd64_edac.c:(.text+0x3e9491): undefined reference to `amd_decode_nb_mce' Ingo Molnar
2009-09-15 13:25   ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090915132549.GA3824@aftab \
    --to=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=norsk5@yahoo.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).