public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: npiggin@suse.de
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [patch 2/5] fs: improve scalability of bdi writeback work queues
Date: Wed, 16 Sep 2009 05:19:05 +1000	[thread overview]
Message-ID: <20090915192242.714632996@suse.de> (raw)
In-Reply-To: 20090915191903.290006007@suse.de

[-- Attachment #1: fs-bdiwb-scale.patch --]
[-- Type: text/plain, Size: 823 bytes --]

If you're going to do an atomic RMW on each list entry, there's not much
point in all the RCU complexities of the list walking. This is only going
to help the multi-thread case I guess, but it doesn't hurt to do now.

Signed-off-by: Nick Piggin <npiggin@suse.de>
---
 fs/fs-writeback.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6/fs/fs-writeback.c
===================================================================
--- linux-2.6.orig/fs/fs-writeback.c
+++ linux-2.6/fs/fs-writeback.c
@@ -736,8 +736,9 @@ static struct bdi_work *get_next_work_it
 	rcu_read_lock();
 
 	list_for_each_entry_rcu(work, &bdi->work_list, list) {
-		if (!test_and_clear_bit(wb->nr, &work->seen))
+		if (!test_bit(wb->nr, &work->seen))
 			continue;
+		clear_bit(wb->nr, &work->seen);
 
 		ret = work;
 		break;



  parent reply	other threads:[~2009-09-15 19:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 19:19 [patch 0/5] bdi writeback fixes npiggin
2009-09-15 19:19 ` [patch 1/5] fs: make use of rcu helpers npiggin
2009-09-15 19:31   ` Jens Axboe
2009-09-15 19:19 ` npiggin [this message]
2009-09-15 19:31   ` [patch 2/5] fs: improve scalability of bdi writeback work queues Jens Axboe
2009-09-15 19:19 ` [patch 3/5] fs: fix bdi writeback use after free 1 npiggin
2009-09-15 19:32   ` Jens Axboe
2009-09-15 19:19 ` [patch 4/5] fs: fix possible bdi writeback refcounting problem npiggin
2009-09-15 19:30   ` Jens Axboe
2009-09-15 19:19 ` [patch 5/5] fs: fix bdi writeback use after free 2 npiggin
2009-09-15 19:29   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090915192242.714632996@suse.de \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox