From: Jens Axboe <jens.axboe@oracle.com>
To: npiggin@suse.de
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/5] fs: make use of rcu helpers
Date: Tue, 15 Sep 2009 21:31:41 +0200 [thread overview]
Message-ID: <20090915193141.GT23126@kernel.dk> (raw)
In-Reply-To: <20090915192242.553693570@suse.de>
On Wed, Sep 16 2009, npiggin@suse.de wrote:
> list_add_tail_rcu contains required barriers.
Thanks, applied as well.
>
> Signed-off-by: Nick Piggin <npiggin@suse.de>
> ---
> fs/fs-writeback.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: linux-2.6/fs/fs-writeback.c
> ===================================================================
> --- linux-2.6.orig/fs/fs-writeback.c
> +++ linux-2.6/fs/fs-writeback.c
> @@ -152,11 +152,6 @@ static void bdi_queue_work(struct backin
> atomic_set(&work->pending, bdi->wb_cnt);
> BUG_ON(!bdi->wb_cnt);
>
> - /*
> - * Make sure stores are seen before it appears on the list
> - */
> - smp_mb();
> -
> spin_lock(&bdi->wb_lock);
> list_add_tail_rcu(&work->list, &bdi->work_list);
> spin_unlock(&bdi->wb_lock);
>
>
--
Jens Axboe
next prev parent reply other threads:[~2009-09-15 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 19:19 [patch 0/5] bdi writeback fixes npiggin
2009-09-15 19:19 ` [patch 1/5] fs: make use of rcu helpers npiggin
2009-09-15 19:31 ` Jens Axboe [this message]
2009-09-15 19:19 ` [patch 2/5] fs: improve scalability of bdi writeback work queues npiggin
2009-09-15 19:31 ` Jens Axboe
2009-09-15 19:19 ` [patch 3/5] fs: fix bdi writeback use after free 1 npiggin
2009-09-15 19:32 ` Jens Axboe
2009-09-15 19:19 ` [patch 4/5] fs: fix possible bdi writeback refcounting problem npiggin
2009-09-15 19:30 ` Jens Axboe
2009-09-15 19:19 ` [patch 5/5] fs: fix bdi writeback use after free 2 npiggin
2009-09-15 19:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915193141.GT23126@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox