Re: [PATCH 06/20] mem_class: use minor as index instead of searching the array

Daniel Walker
2009-09-15T20:06:22Z

On Tue, 2009-09-15 at 21:46 +0200, Kay Sievers wrote:
> On Tue, Sep 15, 2009 at 21:42, Daniel Walker <dwalker@fifo99.com> wrote:
> > On Tue, 2009-09-15 at 12:12 -0700, Greg Kroah-Hartman wrote:
> >> +static const struct memdev {
> >> + const char *name;
> >> + const struct file_operations *fops;
> >> + struct backing_dev_info *dev_info;
> >> +} devlist[] = {
> >> + [ 1] = { "mem", &mem_fops, &directly_mappable_cdev_bdi },
> >
> > This patch has several checkpatch errors wrt. the spacing used in the
> > array index..
> >
> > Kay, can you send a follow up patch to correct them?
>
> I think they are fine, and properly aligned to be best readable.

We already have a coding style in Linux which doesn't allow this type of
alignment .. If we allowed everyone to pick their own coding style we
would have a pretty ugly looking kernel.. That's why the checkpatch tool
was create to test for style conformance.. If you feel strongly about
this alignment you could change checkpatch not to warn on this , but I
don't think it's likely a change like that would be accepted..

Daniel