Re: [PATCH 20/20] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev

Greg KH
2009-09-15T23:46:15Z

On Tue, Sep 15, 2009 at 07:21:04PM -0400, Christoph Hellwig wrote:
> NACK, this touches init code to mount stuff inside the namespace fro ma
> filesystem driver which is a big no-go.

It does? What code is that, the following line in prepare_namespace():
devtmpfs_mount("dev");
?

What is the problem with that?

> I also can't see any ACK or similar from VFS people for that crap
> (obviously)

For that one line? If this call is not the correct way to do this, or
it should be done somewhere else, please let us know.

The patch has been posted for review many times and has been in the
-next and -mm releases for over 2 merge windows, which has gotten it a
lot of exposure and testing and review. This is the first time I recall
this issue being raised.

thanks,

greg k-h