From: Greg KH <gregkh@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
Jan Blunck <jblunck@suse.de>
Subject: Re: [PATCH 20/20] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev
Date: Tue, 15 Sep 2009 16:43:52 -0700 [thread overview]
Message-ID: <20090915234352.GA8911@suse.de> (raw)
In-Reply-To: <20090915232104.GC7636@infradead.org>
On Tue, Sep 15, 2009 at 07:21:04PM -0400, Christoph Hellwig wrote:
> NACK, this touches init code to mount stuff inside the namespace fro ma
> filesystem driver which is a big no-go.
It does? What code is that, the following line in prepare_namespace():
devtmpfs_mount("dev");
?
What is the problem with that?
> I also can't see any ACK or similar from VFS people for that crap
> (obviously)
For that one line? If this call is not the correct way to do this, or
it should be done somewhere else, please let us know.
The patch has been posted for review many times and has been in the
-next and -mm releases for over 2 merge windows, which has gotten it a
lot of exposure and testing and review. This is the first time I recall
this issue being raised.
thanks,
greg k-h
next prev parent reply other threads:[~2009-09-15 23:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 18:12 [GIT PATCH] driver core patches for 2.6.31-git Greg KH
2009-09-15 19:12 ` [PATCH 01/20] Driver core: add new device to bus's list before probing Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 02/20] Driver core: move dev_get/set_drvdata to drivers/base/dd.c Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 03/20] Driver core: Add accessor for device platform data Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 04/20] UIO: remove 'default n' from Kconfig Greg Kroah-Hartman
2009-09-15 19:35 ` Hans J. Koch
2009-09-15 19:12 ` [PATCH 05/20] driver model: constify attribute groups Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 06/20] mem_class: use minor as index instead of searching the array Greg Kroah-Hartman
2009-09-15 19:42 ` Daniel Walker
2009-09-15 19:46 ` Kay Sievers
2009-09-15 20:07 ` Daniel Walker
2009-09-15 20:24 ` Greg KH
2009-09-15 21:18 ` Daniel Walker
2009-09-15 21:20 ` Greg KH
2009-09-15 21:26 ` Daniel Walker
2009-09-15 21:32 ` Greg KH
2009-09-15 22:06 ` Daniel Walker
2009-09-19 15:17 ` Tilman Schmidt
2009-09-19 16:01 ` Daniel Walker
2009-09-15 19:12 ` [PATCH 07/20] mem_class: fix bug Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 08/20] driver-core: move dma-coherent.c from kernel to driver/base Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 09/20] uio: add generic driver for PCI 2.3 devices Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 10/20] Driver core: Add support for compatibility classes Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 11/20] driver core: platform_device_add_data(): use kmemdup() Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 12/20] hpilo: staging for interrupt handling Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 13/20] hpilo: add interrupt handler Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 14/20] hpilo: add poll f_op Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 15/20] debugfs: Fix mount directory of debugfs by default in events.txt Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 16/20] debugfs: Change debuhgfs directory of trace-events-sample.h Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 17/20] debugfs: Change debugfs directory of IWMC3200 Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 18/20] debugfs: Modified default dir of debugfs for debugging UHCI Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 19/20] debugfs: Modify default debugfs directory for debugging pktcdvd Greg Kroah-Hartman
2009-09-15 19:12 ` [PATCH 20/20] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev Greg Kroah-Hartman
2009-09-15 23:21 ` Christoph Hellwig
2009-09-15 23:43 ` Greg KH [this message]
2009-09-16 12:45 ` [GIT PATCH] driver core patches for 2.6.31-git Christoph Hellwig
2009-09-16 12:59 ` Greg KH
2009-09-16 13:15 ` Christoph Hellwig
2009-09-16 13:59 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915234352.GA8911@suse.de \
--to=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=jblunck@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox