From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbZIPNFL (ORCPT ); Wed, 16 Sep 2009 09:05:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752661AbZIPNFH (ORCPT ); Wed, 16 Sep 2009 09:05:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42899 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbZIPNFF (ORCPT ); Wed, 16 Sep 2009 09:05:05 -0400 Date: Wed, 16 Sep 2009 15:05:06 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com, hch@infradead.org, tytso@mit.edu, akpm@linux-foundation.org, jack@suse.cz, trond.myklebust@fys.uio.no Subject: Re: [PATCH 09/11] writeback: separate starting of sync vs opportunistic writeback Message-ID: <20090916130506.GF26030@duck.suse.cz> References: <1253038617-30204-1-git-send-email-jens.axboe@oracle.com> <1253038617-30204-10-git-send-email-jens.axboe@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1253038617-30204-10-git-send-email-jens.axboe@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 15-09-09 20:16:55, Jens Axboe wrote: > bdi_start_writeback() is currently split into two paths, one for > WB_SYNC_NONE and one for WB_SYNC_ALL. Add bdi_sync_writeback() > for WB_SYNC_ALL writeback and let bdi_start_writeback() handle > only WB_SYNC_NONE. > > Push down the writeback_control allocation and only accept the > parameters that make sense for each function. This cleans up > the API considerably. Nice cleanup! > @@ -771,6 +798,8 @@ static long wb_check_old_data_flush(struct bdi_writeback *wb) > struct wb_writeback_args args = { > .nr_pages = nr_pages, > .sync_mode = WB_SYNC_NONE, > + .for_kupdate = 1, > + .range_cyclic = 1, > }; > > return wb_writeback(wb, &args); This chunk should be in patch number 4. Honza -- Jan Kara SUSE Labs, CR