From: Frans Pop <elendil@planet.nl>
To: Wei Chong Tan <weichong78@gmail.com>
Cc: sam@ravnborg.org, max@stro.at, linux-kernel@vger.kernel.org
Subject: Re: PATCH: ARCH in builddeb
Date: Wed, 16 Sep 2009 16:19:31 +0200 [thread overview]
Message-ID: <200909161619.33461.elendil@planet.nl> (raw)
In-Reply-To: <200909142301.17936.elendil@planet.nl>
On Monday 14 September 2009, Frans Pop wrote:
> On Monday 14 September 2009, Wei Chong Tan wrote:
> > I was using "make ARCH=i386 deb-pkg" in the kernel on a 64bit machine
> > and found out that the .deb package created was _amd64.deb.
> > Consequently, I modify the builddeb script to take into account the
> > ARCH environment variable.
>
> Thanks for the patch. I'd like to give it some testing though as I fear
> it may break one other use case that currently somehow does work
> correctly.
>
> If I cross-compile for arm with EABI set in the config, the script
> currently correctly generates an armel package (probably through
> dpkg-cross).
>
> Possibly your change would override that and change it to arm. I don't
> know for sure it will go wrong, but it does need testing. I'll let you
> know.
Yes, it is as I feared. Your patch results in an "arm" package when I do a
cross-build for "armel" (for which I must of course set ARCH to "arm" as
armel is not a valid Linux architecture).
I agree that being able to build i386 on amd64 is a valuable option and I
have actually run into that issue myself (and solved it by building in an
i386 chroot).
A possible solution could be to check that CROSS_COMPILE is *not* set, but
I'm not sure if that would be the correct solution. Input from others on
this would be welcome.
Cheers,
FJP
next prev parent reply other threads:[~2009-09-16 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 5:25 PATCH: ARCH in builddeb Wei Chong Tan
2009-09-14 21:01 ` Frans Pop
2009-09-16 14:19 ` Frans Pop [this message]
2009-09-17 0:12 ` Wei Chong Tan
2009-09-18 3:10 ` Wei Chong Tan
2009-09-20 13:09 ` Frans Pop
2009-09-22 0:38 ` Frans Pop
2009-09-22 14:38 ` Frans Pop
2009-09-22 14:43 ` Wei Chong Tan
2009-09-22 16:53 ` Frans Pop
2009-09-22 23:07 ` Wei Chong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909161619.33461.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=sam@ravnborg.org \
--cc=weichong78@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox