public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: Disable AER with pci=nomsi
@ 2009-09-16 20:40 Andi Kleen
  2009-09-17 16:37 ` Jesse Barnes
  0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2009-09-16 20:40 UTC (permalink / raw)
  To: jbarnes, linux-kernel

PCI: Disable AER with pci=nomsi

When booting with pci=nomsi aer causes lost interrupts and
lockdep inversions.

So check if MSIs are not disabled before initializing the aer
driver.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 drivers/pci/pcie/aer/aerdrv.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/drivers/pci/pcie/aer/aerdrv.c
===================================================================
--- linux.orig/drivers/pci/pcie/aer/aerdrv.c
+++ linux/drivers/pci/pcie/aer/aerdrv.c
@@ -316,6 +316,8 @@ static int __init aer_service_init(void)
 {
 	if (pcie_aer_disable)
 		return -ENXIO;
+	if (!pci_msi_enabled())
+		return -ENXIO;
 	return pcie_port_service_register(&aerdriver);
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-17 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16 20:40 [PATCH] PCI: Disable AER with pci=nomsi Andi Kleen
2009-09-17 16:37 ` Jesse Barnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox