[PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

[PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

[Christian Borntraeger]

commit 85bac32c4a52c592b857f2c360cc5ec93a097d70                                                                                                                             
    ring-buffer: only enable ring_buffer_swap_cpu when needed
broke oprofile (at least on s390, but likely on all platforms).

this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make 
ring_buffer_swap_cpu usable for oprofile.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CC-ed: Steven Rostedt <srostedt@redhat.com> 
CC-ed: Ingo Molnar <mingo@elte.hu>
CC-ed: Robert Richter <robert.richter@amd.com>                                                                                                                      
---
 arch/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/arch/Kconfig
===================================================================
--- linux-2.6.orig/arch/Kconfig
+++ linux-2.6/arch/Kconfig
@@ -9,6 +9,7 @@ config OPROFILE
 	depends on TRACING_SUPPORT
 	select TRACING
 	select RING_BUFFER
+	select RING_BUFFER_ALLOW_SWAP
 	help
 	  OProfile is a profiling system capable of profiling the
 	  whole system, include the kernel, kernel modules, libraries,

Re: [PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

[Steven Rostedt]

On Wed, 2009-09-16 at 21:56 +0200, Christian Borntraeger wrote:
> commit 85bac32c4a52c592b857f2c360cc5ec93a097d70                                                                                                                             
>     ring-buffer: only enable ring_buffer_swap_cpu when needed
> broke oprofile (at least on s390, but likely on all platforms).
> 
> this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make 
> ring_buffer_swap_cpu usable for oprofile.

Thanks, I'll apply this for the 32 queue.

-- Steve

PS. Please send patches to my rostedt@goodmis.org account. I don't
always read my Red Hat email.

> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> CC-ed: Steven Rostedt <srostedt@redhat.com> 
> CC-ed: Ingo Molnar <mingo@elte.hu>
> CC-ed: Robert Richter <robert.richter@amd.com>                                                                                                                      
> ---
>  arch/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux-2.6/arch/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/Kconfig
> +++ linux-2.6/arch/Kconfig
> @@ -9,6 +9,7 @@ config OPROFILE
>  	depends on TRACING_SUPPORT
>  	select TRACING
>  	select RING_BUFFER
> +	select RING_BUFFER_ALLOW_SWAP
>  	help
>  	  OProfile is a profiling system capable of profiling the
>  	  whole system, include the kernel, kernel modules, libraries,

Re: [PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

[Robert Richter]

On 16.09.09 16:11:30, Steven Rostedt wrote:
> On Wed, 2009-09-16 at 21:56 +0200, Christian Borntraeger wrote:
> > commit 85bac32c4a52c592b857f2c360cc5ec93a097d70                                                                                                                             
> >     ring-buffer: only enable ring_buffer_swap_cpu when needed
> > broke oprofile (at least on s390, but likely on all platforms).
> > 
> > this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make 
> > ring_buffer_swap_cpu usable for oprofile.
> 
> Thanks, I'll apply this for the 32 queue.

Thanks Christian,

I was just debugging it for x86 too and narrowed it to the
tracing-core merge already.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com

[tip:tracing/core] oprofile: fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

[tip-bot for Christian Borntraeger]

Commit-ID:  9a5963eb494c8a7be65199e15854551df7d2d939
Gitweb:     http://git.kernel.org/tip/9a5963eb494c8a7be65199e15854551df7d2d939
Author:     Christian Borntraeger <borntraeger@de.ibm.com>
AuthorDate: Wed, 16 Sep 2009 21:56:49 +0200
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 17 Sep 2009 15:53:42 -0400

oprofile: fix oprofile regression: select RING_BUFFER_ALLOW_SWAP

commit 85bac32c4a52c592b857f2c360cc5ec93a097d70
    ring-buffer: only enable ring_buffer_swap_cpu when needed
broke oprofile (at least on s390, but likely on all platforms).

this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make
ring_buffer_swap_cpu usable for oprofile.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
LKML-Reference: <200909162156.49239.borntraeger@de.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>


---
 arch/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index beea3cc..7f418bb 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -9,6 +9,7 @@ config OPROFILE
 	depends on TRACING_SUPPORT
 	select TRACING
 	select RING_BUFFER
+	select RING_BUFFER_ALLOW_SWAP
 	help
 	  OProfile is a profiling system capable of profiling the
 	  whole system, include the kernel, kernel modules, libraries,