public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: sparc64 pcpu failures...
Date: Thu, 17 Sep 2009 22:37:23 -0700 (PDT)	[thread overview]
Message-ID: <20090917.223723.07032792.davem@davemloft.net> (raw)
In-Reply-To: <20090917.221807.208354411.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Thu, 17 Sep 2009 22:18:07 -0700 (PDT)

> 
> Tejun, I just started seeing the following on sparc64:
> 
> [   56.422005] WARNING: at mm/vmalloc.c:1991 pcpu_get_vm_areas+0x1b4/0x5fc()
 ...
> Might this be a result of:
> 
> commit bcb2107fdbecef3de55d597d23453747af81ba88
> Author: Tejun Heo <tj@kernel.org>
> Date:   Fri Aug 14 15:00:53 2009 +0900
> 
>     sparc64: use embedding percpu first chunk allocator
>     
>     sparc64 currently allocates a large page for each cpu and partially
>     remap them into vmalloc area much like what lpage first chunk
>     allocator did.  As a 4M page is used for each cpu, this results in
>     very large unit size and also adds TLB pressure due to the double
>     mapping of pages in the first chunk.
>     
>     This patch converts sparc64 to use the embedding percpu first chunk
>     allocator which now knows how to handle NUMA configurations.  This
>     simplifies the code a lot, doesn't incur any extra TLB pressure and
>     results in better utilization of address space.
>     
>     Signed-off-by: Tejun Heo <tj@kernel.org>
>     Acked-by: David S. Miller <davem@davemloft.net>
> 
> Do you think?

I've verified that reverting this makes the problem go away.

  reply	other threads:[~2009-09-18  5:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18  5:18 sparc64 pcpu failures David Miller
2009-09-18  5:37 ` David Miller [this message]
2009-09-18  8:38   ` Tejun Heo
2009-09-18 17:30     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090917.223723.07032792.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox