Re: [stable] [patch 44/45] PCI: Unhide the SMBus on the Compaq Evo D510 USDT

[Greg KH <greg@kroah.com>]

On Thu, Sep 17, 2009 at 09:58:23AM +0200, Jean Delvare wrote:
> Hi Greg,
> 
> On Wed, 16 Sep 2009 15:36:57 -0700, Greg KH wrote:
> > 2.6.31-stable review patch.  If anyone has any objections, please let us know.
> > 
> > ------------------
> > From: Jean Delvare <khali@linux-fr.org>
> > 
> > commit 6b5096e4d4496e185cd1ada5d1b8e1d941c805ed upstream.
> > 
> > One more form factor for Compaq Evo D510, which needs the same quirk
> > as the other form factors. Apparently there's no hardware monitoring
> > chip on that one, but SPD EEPROMs, so it's still worth unhiding the
> > SMBus.
> 
> FWIW, this one doesn't strike me as being needed in -stable. While it
> should be safe (otherwise it wouldn't have gone upstream in the first
> place), it hardly fulfills -stable's requirement that "it must fix a
> real bug that bothers people". There's no hardware monitoring chip on
> the SMBus on this machine, and people can easily live without detailed
> memory module information.
> 
> So it's up to you, but I won't cry if you drop this patch from -stable.

Heh, you were the one that originally cc:ed the patch to
stable@kernel.org, so I figured you wanted it in.

Quirks like this are simple to add, I have no problem taking it, so
might as well leave it.

thanks,

greg k-h