public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [git pull] first round of PCI updates for 2.6.32
Date: Thu, 17 Sep 2009 20:31:20 +0200	[thread overview]
Message-ID: <20090917183120.GA1675@elte.hu> (raw)
In-Reply-To: <4AB275A1.8020005@kernel.org>


* Yinghai Lu <yinghai@kernel.org> wrote:

> Ingo Molnar wrote:
> > * Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> >> The following changes since commit 332a3392188e0ad966543c87b8da2b9d246f301d:
> >>   Linus Torvalds (1):
> >>         Merge git://git.kernel.org/.../herbert/crypto-2.6
> > 
> > Since this went upstream -tip tests have been triggering nasty bootup 
> > crashes in the PCI code:
> > 
> > [    4.366174] initcall pci_proc_init+0x0/0x7a returned 0 after 976 usecs
> > [    4.373009] calling  pcie_portdrv_init+0x0/0x60 @ 1
> > [    4.378368] bus: 'pci_express': registered
> > [    4.382009] bus: 'pci': add driver pcieport-driver
> > [    4.387058] bus: 'pci': driver_probe_device: matched device 0000:00:0b.0 with driver pcieport-driver
> > [    4.396005] bus: 'pci': really_probe: probing driver pcieport-driver with device 0000:00:0b.0
> > [    4.404056] cpumask_of_node(255): node > nr_node_ids(16)
> 
> please check
> 
> [PATCH] x86/pci: retore 32bit to node0 as default node
> 
> to fix crash on 32bit system
> 
> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
> index 5db96d4..e562ade 100644
> --- a/arch/x86/pci/common.c
> +++ b/arch/x86/pci/common.c
> @@ -646,9 +646,7 @@ int get_mp_bus_to_node(int busnum)
>  
>  #else /* CONFIG_X86_32 */
>  
> -static unsigned char mp_bus_to_node[BUS_NR] = {
> -	[0 ... BUS_NR - 1] = -1
> -};
> +static unsigned char mp_bus_to_node[BUS_NR];
>  
>  void set_mp_bus_to_node(int busnum, int node)
>  {

This seems to have done the trick, thanks!

Tested-by: Ingo Molnar <mingo@elte.hu>

	Ingo

      reply	other threads:[~2009-09-17 18:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 20:21 [git pull] first round of PCI updates for 2.6.32 Jesse Barnes
2009-09-16 14:55 ` Linus Torvalds
2009-09-16 15:20   ` Stephen Rothwell
2009-09-17 17:30 ` Ingo Molnar
2009-09-17 17:36   ` Jesse Barnes
2009-09-17 17:59     ` Ingo Molnar
2009-09-17 18:46       ` Jesse Barnes
2009-09-18  7:59         ` [crash] BUG: unable to handle kernel NULL pointer dereference at (null), last sysfs file: /sys/devices/pci0000:00/0000:00:01.0/local_cpus Ingo Molnar
2009-09-18  9:37           ` David Rientjes
2009-09-18 15:38           ` Linus Torvalds
2009-09-18 15:44             ` Jesse Barnes
2009-09-24  8:18             ` Rusty Russell
2009-09-24 12:18               ` [tip:x86/urgent] x86: Remove redundant non-NUMA topology functions tip-bot for Rusty Russell
2009-09-18 16:24           ` [crash] BUG: unable to handle kernel NULL pointer dereference at (null), last sysfs file: /sys/devices/pci0000:00/0000:00:01.0/local_cpus Yinghai Lu
2009-09-18 16:34             ` Jesse Barnes
2009-09-18 16:51             ` Linus Torvalds
2009-09-18 17:10               ` Jesse Barnes
2009-09-18 15:27       ` [git pull] first round of PCI updates for 2.6.32 Jesse Barnes
2009-09-18 15:52         ` Ingo Molnar
2009-09-18 16:17           ` Jesse Barnes
2009-09-17 17:45   ` Yinghai Lu
2009-09-17 18:31     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090917183120.GA1675@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox