From: Ivo van Doorn <ivdoorn@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Andrew Price <andy@andrewprice.me.uk>, linux-kernel@vger.kernel.org
Subject: Re: rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
Date: Thu, 17 Sep 2009 22:24:37 +0200 [thread overview]
Message-ID: <200909172224.37798.IvDoorn@gmail.com> (raw)
In-Reply-To: <20090917195811.GC2562@tuxdriver.com>
On Thursday 17 September 2009, John W. Linville wrote:
> On Thu, Sep 17, 2009 at 07:11:33PM +0100, Andrew Price wrote:
> > On Thu, Sep 17, 2009 at 01:23:59PM -0400, John W. Linville wrote:
> > > On Thu, Sep 17, 2009 at 04:41:39PM +0100, Andrew Price wrote:
> > > > Hi Ivo,
> > > >
> > > > Apologies if this has already been reported. Building today's mainline
> > > > kernel (ab86e5) I'm seeing this error:
> > > >
> > > > drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:
> > > > drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a cast
> > > > drivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
> > >
> > > Strange...I don't see this warning. Are you sure you have a clean checkout?
> >
> > I double-checked:
> >
> > - git status returned no changes
> > - git clean -fqdx
> > - ccache -C
> > - Retried the build
> >
> > and still got the same error. Is this something to do with the second
> > definition of rt2x00crypto_rx_insert_iv still having an l2pad parameter...
> >
> > This (untested) patch fixes the build for me:
>
> Oh, I see now -- thanks for the patch! FWIW, it would seem to only
> show-up when you have CONFIG_RT2500PCI but none of the other rt2x00
> family drivers in your .config...
Ah yes, that patch looks correct, indeed this is only triggered when only
CONFIG_RT2400PCI and/or CONFIG_RT2500PCI are selected without the
other drivers (which support HW crypto).
Ivo
prev parent reply other threads:[~2009-09-17 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 15:41 rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’ Andrew Price
2009-09-17 17:23 ` John W. Linville
2009-09-17 18:11 ` Andrew Price
2009-09-17 19:58 ` John W. Linville
2009-09-17 20:20 ` Andrew Price
2009-09-17 20:24 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909172224.37798.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=andy@andrewprice.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox