From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] block: Add blk_queue_copy_limits()
Date: Fri, 18 Sep 2009 16:30:40 -0400 [thread overview]
Message-ID: <20090918203040.GA6031@redhat.com> (raw)
In-Reply-To: <yq1eiq46ohz.fsf@sermon.lab.mkp.net>
On Fri, Sep 18 2009 at 3:28pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@ce.jp.nec.com> writes:
>
> + if (q->limits.max_sectors == 0 || q->limits.max_hw_sectors == 0)
> + blk_queue_max_sectors(q, SAFE_MAX_SECTORS);
>
> I'm really not keen on perpetuating SAFE_MAX_SECTORS for something that
> was written in this millennium.
>
> I'd much rather we just do this, then:
>
> block: Set max_sectors correctly for stacking devices
>
> The topology changes unintentionally caused SAFE_MAX_SECTORS to be set
> for stacking devices. Set the default limit to BLK_DEF_MAX_SECTORS and
> provide SAFE_MAX_SECTORS in blk_queue_make_request() for legacy hw
> drivers that depend on the old behavior.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Nice. Avoids the need for a safe queue_limits copy and associated naunce.
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2009-09-18 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 16:24 [PATCH 1/3] block: Add blk_queue_copy_limits() Jun'ichi Nomura
2009-09-18 16:26 ` [PATCH 2/3] dm: Use blk_queue_copy_limits() Jun'ichi Nomura
2009-09-18 19:11 ` Mike Snitzer
2009-09-18 16:29 ` [PATCH 3/3] block: blk_set_default_limits sets 0 to max_sectors Jun'ichi Nomura
2009-09-18 19:07 ` [PATCH 1/3] block: Add blk_queue_copy_limits() Mike Snitzer
2009-09-18 19:28 ` [dm-devel] " Martin K. Petersen
2009-09-18 20:30 ` Mike Snitzer [this message]
2009-09-19 15:22 ` Jun'ichi Nomura
2009-09-20 21:00 ` Martin K. Petersen
2009-09-21 16:33 ` Jun'ichi Nomura
2009-09-21 19:43 ` Martin K. Petersen
2009-09-21 19:45 ` Jens Axboe
2009-09-18 20:33 ` Jens Axboe
2009-09-18 20:35 ` Jens Axboe
2009-09-19 15:35 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918203040.GA6031@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox