From: Pavel Machek <pavel@ucw.cz>
To: Pekka Enberg <penberg@cs.helsinki.fi>, jikos@suse.cz
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
Sandro Bonazzola <sandro.bonazzola@gmail.com>
Subject: Re: [PATCH 7/7] w35und: Remove some write-only struct members
Date: Sat, 19 Sep 2009 12:19:01 +0200 [thread overview]
Message-ID: <20090919101901.GA518@elf.ucw.cz> (raw)
In-Reply-To: <84144f020908120121j542a895fw5f4cdda18890d417@mail.gmail.com>
On Wed 2009-08-12 11:21:53, Pekka Enberg wrote:
> Hi Pavel,
>
> On Wed, Aug 12, 2009 at 11:15 AM, Pavel Machek<pavel@ucw.cz> wrote:
> > On Wed 2009-08-12 11:03:39, Pekka Enberg wrote:
> >> There's no point in keeping around struct members that are only written
> >> to but never read.
> >>
> >> Cc: Pavel Machek <pavel@ucw.cz>
> >> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> >
> > ACK, but... Note I no longer have access to the hardware. It is
> > probably collecting dust in czech suse labs somewhere.
>
> OK, do you still want to be CC'd on the patches? I much appreciate the review!
>
> Btw, is there someone at czech suse labs interested in testing w35und?
> I don't have the hardware either which leaves us with just one
> tester... :-)
Can we get some help? Kohjinsha seems to be one of the very few
machines with that hw...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-09-19 10:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 8:03 [PATCH 1/7] w35und: Commit MDS typedef to struct w35_mds Pekka Enberg
2009-08-12 8:03 ` [PATCH 2/7] w35und: Remove unused struct _RXBUFFER Pekka Enberg
2009-08-12 8:03 ` [PATCH 3/7] w35und: Cleanup the mlmetxrx_f.h header file Pekka Enberg
2009-08-12 8:03 ` [PATCH 4/7] w35und: Convert typedef DESCRIPTOR to struct wb35_descriptor Pekka Enberg
2009-08-12 8:03 ` [PATCH 5/7] w35und: Remove unused struct _STATISTICS_INFO Pekka Enberg
2009-08-12 8:03 ` [PATCH 6/7] w35und: Convert typedef MTO_PARAMETERS to struct wb35_mto_param Pekka Enberg
2009-08-12 8:03 ` [PATCH 7/7] w35und: Remove some write-only struct members Pekka Enberg
2009-08-12 8:15 ` Pavel Machek
2009-08-12 8:21 ` Pekka Enberg
2009-08-12 16:32 ` Sandro Bonazzola
2009-09-19 10:19 ` Pavel Machek [this message]
2009-09-19 10:33 ` Jiri Kosina
2009-08-12 8:14 ` [PATCH 6/7] w35und: Convert typedef MTO_PARAMETERS to struct wb35_mto_param Pavel Machek
2009-08-12 8:13 ` [PATCH 5/7] w35und: Remove unused struct _STATISTICS_INFO Pavel Machek
2009-08-12 8:13 ` [PATCH 4/7] w35und: Convert typedef DESCRIPTOR to struct wb35_descriptor Pavel Machek
2009-08-12 8:10 ` [PATCH 3/7] w35und: Cleanup the mlmetxrx_f.h header file Pavel Machek
2009-08-12 8:10 ` [PATCH 2/7] w35und: Remove unused struct _RXBUFFER Pavel Machek
2009-08-12 8:10 ` [PATCH 1/7] w35und: Commit MDS typedef to struct w35_mds Pavel Machek
2009-08-12 8:24 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919101901.GA518@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@suse.de \
--cc=jikos@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sandro.bonazzola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox