From: Oliver Neukum <oliver@neukum.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] kaweth: Fix memory leak in kaweth_control()
Date: Sat, 19 Sep 2009 21:19:37 +0200 [thread overview]
Message-ID: <200909192119.37988.oliver@neukum.org> (raw)
In-Reply-To: <6a1f935a6229adafb68d0e1ca7bc71fa@localhost>
Am Samstag, 19. September 2009 03:43:30 schrieb Kevin Cernekee:
> kaweth_control() never frees the buffer that it allocates for the USB
> control message. Test case:
>
> while :; do ifconfig eth2 down ; ifconfig eth2 up ; done
>
> This is a tiny buffer so it is a slow leak. If you want to speed up the
> process, you can change the allocation size to e.g. 16384 bytes, and it
> will consume several megabytes within a few minutes.
You are right, the patch is correct. But it has to go to netdev, as it
is for a network driver. Please resend it and add
Acked-by: Oliver Neukum <oliver@neukum.org>
Greg, it should go into stable, too.
Regards
Oliver
next prev parent reply other threads:[~2009-09-19 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 1:43 [PATCH] kaweth: Fix memory leak in kaweth_control() Kevin Cernekee
2009-09-19 19:19 ` Oliver Neukum [this message]
2009-09-22 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909192119.37988.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=cernekee@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox