* [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping
@ 2009-09-07 14:58 Youquan Song
2009-09-09 21:42 ` Suresh Siddha
0 siblings, 1 reply; 6+ messages in thread
From: Youquan Song @ 2009-09-07 14:58 UTC (permalink / raw)
To: mingo, hpa, tglx; +Cc: linux-kernel, dwmw2, Suresh Siddha, youquan.song
Current kernel enable interrupt remapping only when all the vt-d unit support
interrupt remapping. So it is reasonable we should also disallow enabling
intr-remapping if there any io-apics that are not listed under vt-d units.
Otherwise we can run into issues.
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Youquan Song <youquan.song@intel.com>
---
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 7b287cb..a8a4383 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -570,9 +570,6 @@ int __init dmar_table_init(void)
printk(KERN_INFO PREFIX "No ATSR found\n");
#endif
-#ifdef CONFIG_INTR_REMAP
- parse_ioapics_under_ir();
-#endif
return 0;
}
diff --git a/drivers/pci/intr_remapping.c b/drivers/pci/intr_remapping.c
index 4f5b871..ebfa47b 100644
--- a/drivers/pci/intr_remapping.c
+++ b/drivers/pci/intr_remapping.c
@@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
struct dmar_drhd_unit *drhd;
int setup = 0;
+ if (parse_ioapics_under_ir() != 1) {
+ printk(KERN_INFO "Not enable interrupt remapping\n");
+ return -1;
+ }
+
for_each_drhd_unit(drhd) {
struct intel_iommu *iommu = drhd->iommu;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping
2009-09-07 14:58 [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping Youquan Song
@ 2009-09-09 21:42 ` Suresh Siddha
2009-09-09 23:44 ` Song, Youquan
2009-09-20 0:37 ` [PATCH] IR: " Youquan,Song
0 siblings, 2 replies; 6+ messages in thread
From: Suresh Siddha @ 2009-09-09 21:42 UTC (permalink / raw)
To: Song, Youquan
Cc: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, dwmw2@infradead.org
On Mon, 2009-09-07 at 07:58 -0700, Song, Youquan wrote:
> Current kernel enable interrupt remapping only when all the vt-d unit support
> interrupt remapping. So it is reasonable we should also disallow enabling
> intr-remapping if there any io-apics that are not listed under vt-d units.
> Otherwise we can run into issues.
>
> Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
> Signed-off-by: Youquan Song <youquan.song@intel.com>
> ---
>
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index 7b287cb..a8a4383 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -570,9 +570,6 @@ int __init dmar_table_init(void)
> printk(KERN_INFO PREFIX "No ATSR found\n");
> #endif
>
> -#ifdef CONFIG_INTR_REMAP
> - parse_ioapics_under_ir();
> -#endif
> return 0;
> }
>
> diff --git a/drivers/pci/intr_remapping.c b/drivers/pci/intr_remapping.c
> index 4f5b871..ebfa47b 100644
> --- a/drivers/pci/intr_remapping.c
> +++ b/drivers/pci/intr_remapping.c
> @@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
> struct dmar_drhd_unit *drhd;
> int setup = 0;
>
> + if (parse_ioapics_under_ir() != 1) {
> + printk(KERN_INFO "Not enable interrupt remapping\n");
> + return -1;
> + }
> +
> for_each_drhd_unit(drhd) {
> struct intel_iommu *iommu = drhd->iommu;
>
David, Can you also pick this up please?
thanks,
suresh
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping
2009-09-09 21:42 ` Suresh Siddha
@ 2009-09-09 23:44 ` Song, Youquan
2009-09-20 0:37 ` [PATCH] IR: " Youquan,Song
1 sibling, 0 replies; 6+ messages in thread
From: Song, Youquan @ 2009-09-09 23:44 UTC (permalink / raw)
To: Siddha, Suresh B
Cc: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, dwmw2@infradead.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2144 bytes --]
This patch also is promising to go to 2.6.32.
Thanks & Regards,
Song Youquan
Intel SSG/SSD/OTC
MOB: 13681289076
TEL: 010-82171326
INET: 8-758-1326
LOC: Raycom 5W027
> -----Original Message-----
> From: Siddha, Suresh B
> Sent: 2009Äê9ÔÂ10ÈÕ 5:43
> To: Song, Youquan
> Cc: mingo@elte.hu; hpa@zytor.com; tglx@linutronix.de;
> linux-kernel@vger.kernel.org; dwmw2@infradead.org
> Subject: Re: [PATCH] interrupt remapping: Disallow interrupt
> remapping if not all ioapic under interrupt remapping
>
> On Mon, 2009-09-07 at 07:58 -0700, Song, Youquan wrote:
> > Current kernel enable interrupt remapping only when all the
> vt-d unit support
> > interrupt remapping. So it is reasonable we should also
> disallow enabling
> > intr-remapping if there any io-apics that are not listed
> under vt-d units.
> > Otherwise we can run into issues.
> >
> > Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
> > Signed-off-by: Youquan Song <youquan.song@intel.com>
> > ---
> >
> > diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> > index 7b287cb..a8a4383 100644
> > --- a/drivers/pci/dmar.c
> > +++ b/drivers/pci/dmar.c
> > @@ -570,9 +570,6 @@ int __init dmar_table_init(void)
> > printk(KERN_INFO PREFIX "No ATSR found\n");
> > #endif
> >
> > -#ifdef CONFIG_INTR_REMAP
> > - parse_ioapics_under_ir();
> > -#endif
> > return 0;
> > }
> >
> > diff --git a/drivers/pci/intr_remapping.c
> b/drivers/pci/intr_remapping.c
> > index 4f5b871..ebfa47b 100644
> > --- a/drivers/pci/intr_remapping.c
> > +++ b/drivers/pci/intr_remapping.c
> > @@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
> > struct dmar_drhd_unit *drhd;
> > int setup = 0;
> >
> > + if (parse_ioapics_under_ir() != 1) {
> > + printk(KERN_INFO "Not enable interrupt remapping\n");
> > + return -1;
> > + }
> > +
> > for_each_drhd_unit(drhd) {
> > struct intel_iommu *iommu = drhd->iommu;
> >
>
> David, Can you also pick this up please?
>
> thanks,
> suresh
>
> ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] IR: Disallow interrupt remapping if not all ioapic under interrupt remapping
2009-09-09 21:42 ` Suresh Siddha
2009-09-09 23:44 ` Song, Youquan
@ 2009-09-20 0:37 ` Youquan,Song
2009-09-19 17:07 ` David Woodhouse
1 sibling, 1 reply; 6+ messages in thread
From: Youquan,Song @ 2009-09-20 0:37 UTC (permalink / raw)
To: dwmw2, Suresh Siddha
Cc: Song, Youquan, mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, dwmw2@infradead.org
On Wed, Sep 09, 2009 at 02:42:55PM -0700, Suresh Siddha wrote:
> On Mon, 2009-09-07 at 07:58 -0700, Song, Youquan wrote:
> > Current kernel enable interrupt remapping only when all the vt-d unit support
> > interrupt remapping. So it is reasonable we should also disallow enabling
> > intr-remapping if there any io-apics that are not listed under vt-d units.
> > Otherwise we can run into issues.
> >
> > Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
> > Signed-off-by: Youquan Song <youquan.song@intel.com>
> > ---
> >
> > diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> > index 7b287cb..a8a4383 100644
> > --- a/drivers/pci/dmar.c
> > +++ b/drivers/pci/dmar.c
> > @@ -570,9 +570,6 @@ int __init dmar_table_init(void)
> > printk(KERN_INFO PREFIX "No ATSR found\n");
> > #endif
> >
> > -#ifdef CONFIG_INTR_REMAP
> > - parse_ioapics_under_ir();
> > -#endif
> > return 0;
> > }
> >
> > diff --git a/drivers/pci/intr_remapping.c b/drivers/pci/intr_remapping.c
> > index 4f5b871..ebfa47b 100644
> > --- a/drivers/pci/intr_remapping.c
> > +++ b/drivers/pci/intr_remapping.c
> > @@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
> > struct dmar_drhd_unit *drhd;
> > int setup = 0;
> >
> > + if (parse_ioapics_under_ir() != 1) {
> > + printk(KERN_INFO "Not enable interrupt remapping\n");
> > + return -1;
> > + }
> > +
> > for_each_drhd_unit(drhd) {
> > struct intel_iommu *iommu = drhd->iommu;
> >
>
> David, Can you also pick this up please?
>
> thanks,
> suresh
Change the patch title to short one.
David, Couly you please also pick this up? Sorry, if you have done.
Thanks.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] IR: Disallow interrupt remapping if not all ioapic under interrupt remapping
2009-09-20 0:37 ` [PATCH] IR: " Youquan,Song
@ 2009-09-19 17:07 ` David Woodhouse
2009-09-20 0:55 ` Youquan,Song
0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2009-09-19 17:07 UTC (permalink / raw)
To: Youquan,Song
Cc: Suresh Siddha, Song, Youquan, mingo@elte.hu, hpa@zytor.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org
On Sat, 2009-09-19 at 20:37 -0400, Youquan,Song wrote:
> Change the patch title to short one.
> David, Couly you please also pick this up? Sorry, if you have done.
http://git.infradead.org/iommu-2.6.git?commit=e936d0773df
I changed the title when I committed it.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IR: Disallow interrupt remapping if not all ioapic under interrupt remapping
2009-09-19 17:07 ` David Woodhouse
@ 2009-09-20 0:55 ` Youquan,Song
0 siblings, 0 replies; 6+ messages in thread
From: Youquan,Song @ 2009-09-20 0:55 UTC (permalink / raw)
To: David Woodhouse
Cc: Youquan,Song, Suresh Siddha, Song, Youquan, mingo@elte.hu,
hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org
On Sat, Sep 19, 2009 at 10:07:01AM -0700, David Woodhouse wrote:
> On Sat, 2009-09-19 at 20:37 -0400, Youquan,Song wrote:
> > Change the patch title to short one.
> > David, Couly you please also pick this up? Sorry, if you have done.
>
> http://git.infradead.org/iommu-2.6.git?commit=e936d0773df
>
> I changed the title when I committed it.
>
Fine, your title is better than mine. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-09-19 17:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-07 14:58 [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping Youquan Song
2009-09-09 21:42 ` Suresh Siddha
2009-09-09 23:44 ` Song, Youquan
2009-09-20 0:37 ` [PATCH] IR: " Youquan,Song
2009-09-19 17:07 ` David Woodhouse
2009-09-20 0:55 ` Youquan,Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox